Move PyVmomiDeviceHelper to module_utils.vm_device_helper #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariolenz
force-pushed
the
module_utils.vmware_guest
branch
2 times, most recently
from
a42450a to
53dd63e
Compare
mariolenz
force-pushed
the
module_utils.vmware_guest
branch
from
53dd63e to
3efd70c
Compare
|
recheck |
Tomorrow9
reviewed
Jun 23, 2021
mariolenz
force-pushed
the
module_utils.vmware_guest
branch
from
070f248 to
cb4ea2d
Compare
mariolenz
force-pushed
the
module_utils.vmware_guest
branch
from
cb4ea2d to
6716e08
Compare
|
recheck |
mariolenz
changed the title
|
@sky-joker @Tomorrow9 What do you think, should we merge this? Then we could try to refactor |
mariolenz
changed the title
Akasurde
approved these changes
Jun 25, 2021
ansible-zuul bot
pushed a commit
that referenced
this pull request
Jun 29, 2021
vmware_guest_disk: Use functions from module_utils SUMMARY Remove duplicate code from vmware_guest_disk by using the functions from module_utils.vm_device_helper. PyVmomiDeviceHelper. ISSUE TYPE Feature Pull Request COMPONENT NAME vmware_guest_disk ADDITIONAL INFORMATION Follow-up to PR #909 Reviewed-by: Diane Wang <None> Reviewed-by: sky-joker <[email protected]>
This was referenced Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I think we should move the class
PyVmomiDeviceHelperfromvmware_guestto a module util. This way, we can use it in other modules (likevmware_guest_disk) and avoid duplicate code. In the long run, I hope this'll make it easier for us to maintain this collection.ISSUE TYPE
COMPONENT NAME
vmware_guest
ADDITIONAL INFORMATION
Context: #905