Set export on Config to verbose #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SUMMARY In the configuration export session i think that using /export verbose is better than just /export, because with export only some configurations sections are going to be missed like BGP configuration, as proposed in ansible/ansible#67868 ISSUE TYPE Bugfix Pull Request COMPONENT NAME routeros_facts.py ADDITIONAL INFORMATION extract of the output with /export verbose # software id = # # # /interface ethernet set [ find default-name=ether1 ] advertise=\ 10M-half,10M-full,100M-half,100M-full,1000M-full arp=enabled arp-timeout=\ auto auto-negotiation=yes cable-settings=default disable-running-check=\ yes disabled=no full-duplex=yes loop-protect=default \ loop-protect-disable-time=5m loop-protect-send-interval=5s mac-address=\ 50:00:00:02:00:00 mtu=1500 name=ether1 orig-mac-address=50:00:00:02:00:00 \ rx-flow-control=off speed=1Gbps tx-flow-control=off set [ find default-name=ether2 ] advertise=\ 10M-half,10M-full,100M-half,100M-full,1000M-full arp=enabled arp-timeout=\ auto auto-negotiation=yes cable-settings=default disable-running-check=\ yes disabled=no full-duplex=yes loop-protect=default \ loop-protect-disable-time=5m loop-protect-send-interval=5s mac-address=\ 50:00:00:02:00:01 mtu=1500 name=ether2 orig-mac-address=50:00:00:02:00:01 \ rx-flow-control=off speed=1Gbps tx-flow-control=off set [ find default-name=ether3 ] advertise=\ ..... ..... Extract of Output with only /export: # software id = # # # /interface wireless security-profiles set [ find default=yes ] supplicant-identity=MikroTik /ip dhcp-client add dhcp-options=hostname,clientid disabled=no interface=ether1 <END>
|
Could you please add a changelog fragment (probably CC @heuels |
Co-authored-by: Felix Fontein <[email protected]>
|
You probably also need to rename the unit test fixture file (as you did in ansible/ansible#67868). It now lives in tests/unit/plugins/modules/network/routeros/fixtures/routeros_facts/. |
|
Looks good to me. @heuels what do you think? |
|
@felixfontein, yes, it looks great – let's merge it 🙂 |
|
@heuels aaaand... done! :) thanks for reviewing this! |
felixfontein
added
the
needs_backport_to_stable_1
felixfontein
added
backport-stable-1
and removed
needs_backport_to_stable_1
patchback bot
pushed a commit
that referenced
this pull request
Sep 17, 2020
* Set export on Config to verbose SUMMARY In the configuration export session i think that using /export verbose is better than just /export, because with export only some configurations sections are going to be missed like BGP configuration, as proposed in ansible/ansible#67868 ISSUE TYPE Bugfix Pull Request COMPONENT NAME routeros_facts.py ADDITIONAL INFORMATION extract of the output with /export verbose # software id = # # # /interface ethernet set [ find default-name=ether1 ] advertise=\ 10M-half,10M-full,100M-half,100M-full,1000M-full arp=enabled arp-timeout=\ auto auto-negotiation=yes cable-settings=default disable-running-check=\ yes disabled=no full-duplex=yes loop-protect=default \ loop-protect-disable-time=5m loop-protect-send-interval=5s mac-address=\ 50:00:00:02:00:00 mtu=1500 name=ether1 orig-mac-address=50:00:00:02:00:00 \ rx-flow-control=off speed=1Gbps tx-flow-control=off set [ find default-name=ether2 ] advertise=\ 10M-half,10M-full,100M-half,100M-full,1000M-full arp=enabled arp-timeout=\ auto auto-negotiation=yes cable-settings=default disable-running-check=\ yes disabled=no full-duplex=yes loop-protect=default \ loop-protect-disable-time=5m loop-protect-send-interval=5s mac-address=\ 50:00:00:02:00:01 mtu=1500 name=ether2 orig-mac-address=50:00:00:02:00:01 \ rx-flow-control=off speed=1Gbps tx-flow-control=off set [ find default-name=ether3 ] advertise=\ ..... ..... Extract of Output with only /export: # software id = # # # /interface wireless security-profiles set [ find default=yes ] supplicant-identity=MikroTik /ip dhcp-client add dhcp-options=hostname,clientid disabled=no interface=ether1 <END> * Create 104_routeros_facts_export_verbose * Update changelogs/fragments/104_routeros_facts_export_verbose Co-authored-by: Felix Fontein <[email protected]> * Rename export to export_verbose * Rename 104_routeros_facts_export_verbose to 104_routeros_facts_export_verbose.yml Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit feb89c9)
felixfontein
pushed a commit
that referenced
this pull request
Sep 17, 2020
* Set export on Config to verbose SUMMARY In the configuration export session i think that using /export verbose is better than just /export, because with export only some configurations sections are going to be missed like BGP configuration, as proposed in ansible/ansible#67868 ISSUE TYPE Bugfix Pull Request COMPONENT NAME routeros_facts.py ADDITIONAL INFORMATION extract of the output with /export verbose # software id = # # # /interface ethernet set [ find default-name=ether1 ] advertise=\ 10M-half,10M-full,100M-half,100M-full,1000M-full arp=enabled arp-timeout=\ auto auto-negotiation=yes cable-settings=default disable-running-check=\ yes disabled=no full-duplex=yes loop-protect=default \ loop-protect-disable-time=5m loop-protect-send-interval=5s mac-address=\ 50:00:00:02:00:00 mtu=1500 name=ether1 orig-mac-address=50:00:00:02:00:00 \ rx-flow-control=off speed=1Gbps tx-flow-control=off set [ find default-name=ether2 ] advertise=\ 10M-half,10M-full,100M-half,100M-full,1000M-full arp=enabled arp-timeout=\ auto auto-negotiation=yes cable-settings=default disable-running-check=\ yes disabled=no full-duplex=yes loop-protect=default \ loop-protect-disable-time=5m loop-protect-send-interval=5s mac-address=\ 50:00:00:02:00:01 mtu=1500 name=ether2 orig-mac-address=50:00:00:02:00:01 \ rx-flow-control=off speed=1Gbps tx-flow-control=off set [ find default-name=ether3 ] advertise=\ ..... ..... Extract of Output with only /export: # software id = # # # /interface wireless security-profiles set [ find default=yes ] supplicant-identity=MikroTik /ip dhcp-client add dhcp-options=hostname,clientid disabled=no interface=ether1 <END> * Create 104_routeros_facts_export_verbose * Update changelogs/fragments/104_routeros_facts_export_verbose Co-authored-by: Felix Fontein <[email protected]> * Rename export to export_verbose * Rename 104_routeros_facts_export_verbose to 104_routeros_facts_export_verbose.yml Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit feb89c9) Co-authored-by: Renato Almeida de Oliveira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In the configuration export session i think that using /export verbose is better than just /export, because with export only some configurations sections are going to be missed like BGP configuration, as proposed in ansible/ansible#67868
ISSUE TYPE
Minor Change Request
COMPONENT NAME
routeros_facts.py
ADDITIONAL INFORMATION
extract of the output with /export verbose
Extract of Output with only /export: