Skip to content

Commit

Permalink
Set export on Config to verbose (#104)
Browse files Browse the repository at this point in the history
* Set export on Config to verbose

SUMMARY
In the configuration export session i think that using /export verbose is better than just /export, because with export only some configurations sections are going to be missed like BGP configuration, as proposed in ansible/ansible#67868

ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
routeros_facts.py

ADDITIONAL INFORMATION
extract of the output with /export verbose


# software id = 
#
#
#
/interface ethernet
set [ find default-name=ether1 ] advertise=\
    10M-half,10M-full,100M-half,100M-full,1000M-full arp=enabled arp-timeout=\
    auto auto-negotiation=yes cable-settings=default disable-running-check=\
    yes disabled=no full-duplex=yes loop-protect=default \
    loop-protect-disable-time=5m loop-protect-send-interval=5s mac-address=\
    50:00:00:02:00:00 mtu=1500 name=ether1 orig-mac-address=50:00:00:02:00:00 \
    rx-flow-control=off speed=1Gbps tx-flow-control=off
set [ find default-name=ether2 ] advertise=\
    10M-half,10M-full,100M-half,100M-full,1000M-full arp=enabled arp-timeout=\
    auto auto-negotiation=yes cable-settings=default disable-running-check=\
    yes disabled=no full-duplex=yes loop-protect=default \
    loop-protect-disable-time=5m loop-protect-send-interval=5s mac-address=\
    50:00:00:02:00:01 mtu=1500 name=ether2 orig-mac-address=50:00:00:02:00:01 \
    rx-flow-control=off speed=1Gbps tx-flow-control=off
set [ find default-name=ether3 ] advertise=\ 
.....
.....
Extract of Output with only /export:
# software id = 
#
#
#
/interface wireless security-profiles
set [ find default=yes ] supplicant-identity=MikroTik
/ip dhcp-client
add dhcp-options=hostname,clientid disabled=no interface=ether1
<END>

* Create 104_routeros_facts_export_verbose

* Update changelogs/fragments/104_routeros_facts_export_verbose

Co-authored-by: Felix Fontein <[email protected]>

* Rename export to export_verbose

* Rename 104_routeros_facts_export_verbose to 104_routeros_facts_export_verbose.yml

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit feb89c9)
  • Loading branch information
renatoalmeidaoliveira authored and Patchback committed Sep 17, 2020
1 parent d1c5cea commit 9612e61
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions changelogs/fragments/104_routeros_facts_export_verbose.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
minor_changes:
- routeros_facts - set configuration export on to verbose, for full configuration export (https://github.com/ansible-collections/community.network/pull/104).
2 changes: 1 addition & 1 deletion plugins/modules/network/routeros/routeros_facts.py
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ def to_megabytes(self, data):

class Config(FactsBase):

COMMANDS = ['/export']
COMMANDS = ['/export verbose']

def populate(self):
super(Config, self).populate()
Expand Down

0 comments on commit 9612e61

Please sign in to comment.