Prevent parted warnings in script mode

[oldmanhere]

SUMMARY

Add automatic answer "fix" when script mode -s is used with parted version >= 3.4.64

Comments from the project parted :
automatically answer exceptions with "fix" in script mode, which is useful for:
GPT header not including full disk size;
moving the backup GPT table to the end of the disk;
MAC fix missing partition map entry;
etc.
see: https://www.mail-archive.com/[email protected]/msg00369.html

Fixes #1653 #1461

minor_changes:

• parted - on resize, use --fix option if available

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

parted

ADDITIONAL INFORMATION

just use -f with -s and resizepart in the same command.

Before:
When you enhance the drive on the vcenter, and refresh in the OS, the community.general.parted with resize=true hang like that:

Warning: Not all of the space available to /dev/sdx appears to be used, you can fix the GPT to use all of the space (an extra xxxxx blocks) or continue with the current setting? 
Error: Unable to satisfy all constraints on the partition.

After:
the resize is done correctly.

[ansibullbot]

cc @ColOfAbRiX @jake2184 @rosowiecki
click here for bot help

[oldmanhere]

This can fix #1461 too

[felixfontein]

Thanks for your contribution! Can you please add a changelog fragment? Thanks.

[felixfontein]

Also please note that integration tests are failing on several platforms, where parted doesn't support -f (or it doesn't support it in the situation where it is used).

"err": "/usr/sbin/parted: invalid option -- 'f'\nUsage: /usr/sbin/parted [-hlmsv] [-a] [DEVICE [COMMAND [PARAMETERS]]...]\n"

[oldmanhere]

Changelog fragment added. Please modify if needed, as i'm not fluent in english.

[felixfontein]

@oldmanhere in case you added it you probably forgot to push it, since it isn't here :)

[oldmanhere]

@felixfontein

I have added in the first post :

breaking_changes:
parted - resize : Use --fix option by default (Note: --fix from parted 3.5. If you use a old version, please update)

It's not what i have to do ?

[felixfontein]

The changelog fragment needs to be a file inside your PR, see https://docs.ansible.com/ansible/devel/community/collection_development_process.html#creating-a-changelog-fragment:

A basic changelog fragment is a .yaml or .yml file placed in the changelogs/fragments/ directory. Each file contains a yaml dict with keys like bugfixes or major_changes followed by a list of changelog entries of bugfixes or features.

But in any case, please note that your PR cannot be merged in this form since it is a breaking change, and breaking changes need a long enough deprecation period. See your policy on deprecation in #582 (comment).

To make your PR also work with older versions of parted, you can use the parted_version function (grep for it in the code of the module), and you need to figure out which version of parted added support for --fix.

[oldmanhere]

@felixfontein Thanks for your advice. I have adjust the code to take care of the parted version. It's no longer a 3chars patch and no more a breaking change one.

Now, i just need to understand how to amend this pr.

[oldmanhere]

the fragment seems to be good now.

[felixfontein]

Looks good as far as I can judge! I will merge next weekend if nobody objects.

[patchback]

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/324c22f6129864ea69ce866b19ca58fd8857b25c/pr-7304

Backported as #7365

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[felixfontein]

@oldmanhere thanks for your contribution!