Add snapshot_id option to vmware_guest_snapshot module #1847
Conversation
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 37s |
sky-joker
changed the title
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 26s |
|
recheck |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 9m 29s |
|
@sky-joker Are there any fixes in the CI environment? |
|
Hi @ihumster and @sky-joker, It looks like the images need to be rebuild, Cc: @jillr, @alinabuzachis, @abikouo. |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 38s |
|
I had started the esxi rebuild last night, the vcsa will build today. I'll try to have everything uploaded by end of day (US west). |
|
@jillr Is there somewhere I can find out more about the structure of the current VMware environment of our CI process? Maybe we could help with something? Perhaps there is a wiki page about this? Now I have a very general understanding of how our CI works. |
|
recheck |
|
@ihumster Other than the info in #1746 and the process for building the images, there isn't anything that comprehensively covers the VMware-specific portions of the Software Factory / Zuul config. One of the main challenges is the need for infrastructure to run VMware and automation to deploy on-demand environments on that infrastructure. |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 38s |
|
recheck |
1 similar comment
|
recheck |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 36s |
|
recheck |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 30s |
|
@jillr It looks like we still get the |
|
Apologies, I meant to leave a comment here but the galaxy cutover is also causing all kinds of issues for us. |
|
We're uploading new images now |
|
recheck |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 37s |
|
I really don't understand what's happening at this point; images that were rebuilt earlier today are throwing license errors in the latest log. We'll have to think about what options we have going forward. |
|
recheck |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 38s |
|
I re-generated the esxi image and uploaded. It seems the error is different now, no more a license error. I have also re-generated the vcsa images (just to be sure) and started the upload process (it will take me a while). |
|
recheck |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 9m 37s |
|
@jillr @mariolenz license errors seems fixed with the regenerated images, what I'm seeing right now, if I am not mistaken, is due to a timeout. |
|
recheck |
|
@alinabuzachis Great, that's awesome! Thanks! We've always had weird failures in the CI, but they've mostly been temporary. One or two rechecks usually helped. I agree that the license issue seems to be fixed, and that's the important thing :-) |
|
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 8m 28s |
|
Build succeeded 🎉 Thanks @alinabuzachis @jillr for working on this! |
|
Build succeeded (gate pipeline). ✔️ ansible-tox-linters SUCCESS in 8m 34s |
softwarefactory-project-zuul
bot
merged commit f94611b
into
ansible-collections:main
8.5.0 amazon.aws ~~~~~~~~~~ - ec2_ami - add support for ``org_arns`` and ``org_unit_arns`` in launch_permissions (ansible-collections/amazon.aws#1690). - elb_application_lb_info - drop redundant ``describe_load_balancers`` call fetching ``ip_address_type`` (ansible-collections/amazon.aws#1768). community.general ~~~~~~~~~~~~~~~~~ - cargo - add option ``executable``, which allows user to specify path to the cargo binary (ansible-collections/community.general#7352). - cargo - add option ``locked`` which allows user to specify install the locked version of dependency instead of latest compatible version (ansible-collections/community.general#6134). - dig lookup plugin - add TCP option to enable the use of TCP connection during DNS lookup (ansible-collections/community.general#7343). - gitlab_group - add option ``force_delete`` (default: false) which allows delete group even if projects exists in it (ansible-collections/community.general#7364). - ini_file - add ``ignore_spaces`` option (ansible-collections/community.general#7273). - newrelic_deployment - add option ``app_name_exact_match``, which filters results for the exact app_name provided (ansible-collections/community.general#7355). - onepassword lookup plugin - introduce ``account_id`` option which allows specifying which account to use (ansible-collections/community.general#7308). - onepassword_raw lookup plugin - introduce ``account_id`` option which allows specifying which account to use (ansible-collections/community.general#7308). - parted - on resize, use ``--fix`` option if available (ansible-collections/community.general#7304). - pnpm - set correct version when state is latest or version is not mentioned. Resolves previous idempotency problem (ansible-collections/community.general#7339). - proxmox - add ``vmid`` (and ``taskid`` when possible) to return values (ansible-collections/community.general#7263). - random_string - added new ``ignore_similar_chars`` and ``similar_chars`` option to ignore certain chars (ansible-collections/community.general#7242). - redfish_command - add new option ``update_oem_params`` for the ``MultipartHTTPPushUpdate`` command (ansible-collections/community.general#7331). - redfish_config - add ``CreateVolume`` command to allow creation of volumes on servers (ansible-collections/community.general#6813). - redfish_config - adding ``SetSecureBoot`` command (ansible-collections/community.general#7129). - redfish_info - add support for ``GetBiosRegistries`` command (ansible-collections/community.general#7144). - redfish_info - adds ``LinkStatus`` to NIC inventory (ansible-collections/community.general#7318). - redis_info - refactor the redis_info module to use the redis module_utils enabling to pass TLS parameters to the Redis client (ansible-collections/community.general#7267). - supervisorctl - allow to stop matching running processes before removing them with ``stop_before_removing=true`` (ansible-collections/community.general#7284). community.libvirt ~~~~~~~~~~~~~~~~~ - virt - add `mutate_flags` parameter to enable XML mutation (add UUID, MAC addresses from existing domain) (ansible-collections/community.libvirt#142). - virt - support ``--diff`` for ``define`` command (ansible-collections/community.libvirt#142). community.routeros ~~~~~~~~~~~~~~~~~~ - api_info - add new ``include_read_only`` option to select behavior for read-only values. By default these are not returned (ansible-collections/community.routeros#213). - api_info, api_modify - add support for ``address-list`` and ``match-subdomain`` introduced by RouterOS 7.7 in the ``ip dns static`` path (ansible-collections/community.routeros#197). - api_info, api_modify - add support for ``user``, ``time`` and ``gmt-offset`` under the ``system clock`` path (ansible-collections/community.routeros#210). - api_info, api_modify - add support for the ``interface ppp-client`` path (ansible-collections/community.routeros#199). - api_info, api_modify - add support for the ``interface wireless`` path (ansible-collections/community.routeros#195). - api_info, api_modify - add support for the ``iot modbus`` path (ansible-collections/community.routeros#205). - api_info, api_modify - add support for the ``ip dhcp-server option`` and ``ip dhcp-server option sets`` paths (ansible-collections/community.routeros#223). - api_info, api_modify - add support for the ``ip upnp interfaces``, ``tool graphing interface``, ``tool graphing resource`` paths (ansible-collections/community.routeros#227). - api_info, api_modify - add support for the ``ipv6 firewall nat`` path (ansible-collections/community.routeros#204). - api_info, api_modify - add support for the ``mode`` property in ``ip neighbor discovery-settings`` introduced in RouterOS 7.7 (ansible-collections/community.routeros#198). - api_info, api_modify - add support for the ``port remote-access`` path (ansible-collections/community.routeros#224). - api_info, api_modify - add support for the ``routing filter rule`` and ``routing filter select-rule`` paths (ansible-collections/community.routeros#200). - api_info, api_modify - add support for the ``routing table`` path in RouterOS 7 (ansible-collections/community.routeros#215). - api_info, api_modify - add support for the ``tool netwatch`` path in RouterOS 7 (ansible-collections/community.routeros#216). - api_info, api_modify - add support for the ``user settings`` path (ansible-collections/community.routeros#201). - api_info, api_modify - add support for the ``user`` path (ansible-collections/community.routeros#211). - api_info, api_modify - finalize fields for the ``interface wireless security-profiles`` path and enable it (ansible-collections/community.routeros#203). - api_info, api_modify - finalize fields for the ``ppp profile`` path and enable it (ansible-collections/community.routeros#217). - api_modify - add new ``handle_read_only`` and ``handle_write_only`` options to handle the module's behavior for read-only and write-only fields (ansible-collections/community.routeros#213). - api_modify, api_info - support API paths ``routing id``, ``routing bgp connection`` (ansible-collections/community.routeros#220). community.vmware ~~~~~~~~~~~~~~~~ - add moid property in the return value for the module(ansible-collections/community.vmware#1855). - add new snapshot_id option to the vmware_guest_snapshot module(ansible-collections/community.vmware#1847). dellemc.powerflex ~~~~~~~~~~~~~~~~~ - Added Ansible role to support installation and uninstallation of Gateway. - Added Ansible role to support installation and uninstallation of SDR. - Added Ansible role to support installation and uninstallation of Web UI. grafana.grafana ~~~~~~~~~~~~~~~ - Add check for Curl and failure step if Agent Version is not retrieved - Allow alert resource provisioning in Grafana Role - Bump cryptography from 39.0.2 to 41.0.3 - Bump cryptography from 41.0.3 to 41.0.4 - Bump semver from 5.7.1 to 5.7.2 - Bump word-wrap from 1.2.3 to 1.2.5 - Create local dashboard directory in check mode - Create missing notification directory in Grafana Role - Remove check_mode from create local directory task in Grafana Role - Remove dependency on local-fs.target from Grafana Agent role - Update CI Testing - Update Cloud Stack Module failures - Use 'ansible_system' env variable to detect os typ in Grafana Agent Role - hange grafana Agent Wal and Positions Directory in Grafana Agent Role ovirt.ovirt ~~~~~~~~~~~ - ovirt_vm - Add tpm_enabled (oVirt/ovirt-ansible-collection#722). - storage_error_resume_behaviour - Support VM storage error resume behaviour "auto_resume", "kill", "leave_paused". (oVirt/ovirt-ansible-collection#721) - vm_infra - Support boot disk renaming and resizing. (oVirt/ovirt-ansible-collection#705) purestorage.flashblade ~~~~~~~~~~~~~~~~~~~~~~ - purefb_bucket_replica - Added support for cascading replica links - purefb_info - New fields to display free space (remaining quota) for Accounts and Buckets. Space used by destroyed buckets is split out from virtual field to new destroyed_virtual field - purefb_info - Report encryption state in SMB client policy rules - purefb_info - Report more detailed space data from Purity//FB 4.3.0 - purefb_policy - Add deny effect for object store policy rules. Requires Purity//FB 4.3.0+ - purefb_policy - Added parameter to define object store policy description vultr.cloud ~~~~~~~~~~~ - inventory - Added VPC/VPC 2.0 support by adding ``internal_ip`` to the attributes (vultr/ansible-collection-vultr#86).
|
Thanks all :) |
SUMMARY
This PR is to add snapshot_id option to the module.
fixes: #1844
ISSUE TYPE
COMPONENT NAME
changelogs/fragments/1847_vmware_guest_snapshot.yml
docs/community.vmware.vmware_guest_snapshot_module.rst
plugins/modules/vmware_guest_snapshot.py
tests/integration/targets/vmware_guest_snapshot/tasks/main.yml
ADDITIONAL INFORMATION
I will add the integration test in a few days.Done