Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent parted warnings in script mode #7304

Merged
merged 12 commits into from
Oct 8, 2023
Merged

Prevent parted warnings in script mode #7304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3c70828
Prevent parted warnings in script mode
oldmanhere Sep 21, 2023
3e9e231
Update parted.py with check parted version
oldmanhere Oct 3, 2023
847aac6
Typo
oldmanhere Oct 3, 2023
add8854
Create 7304-prevent-parted-warnings.yml
oldmanhere Oct 3, 2023
4be5038
Update 7304-prevent-parted-warnings.yml
oldmanhere Oct 3, 2023
414ff61
Update 7304-prevent-parted-warnings.yml
oldmanhere Oct 3, 2023
ddc10c4
Update 7304-prevent-parted-warnings.yml
oldmanhere Oct 3, 2023
c128fe3
Update 7304-prevent-parted-warnings.yml
oldmanhere Oct 3, 2023
7dd74c0
Update 7304-prevent-parted-warnings.yml
oldmanhere Oct 3, 2023
5a8d7c5
Update changelogs/fragments/7304-prevent-parted-warnings.yml
oldmanhere Oct 4, 2023
a10ff17
Update plugins/modules/parted.py
oldmanhere Oct 4, 2023
c3e352b
Update parted.py - simplification
oldmanhere Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/7304-prevent-parted-warnings.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
minor_changes:
- parted - on resize, use ``--fix`` option if available (https://github.com/ansible-collections/community.general/pull/7304).
12 changes: 11 additions & 1 deletion plugins/modules/parted.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,8 +569,18 @@ def parted(script, device, align):
if align == 'undefined':
align_option = ''

"""
Use option --fix (-f) if available. Versions prior
to 3.4.64 don't have it. For more information see:
http://savannah.gnu.org/news/?id=10114
"""
if parted_version() >= (3, 4, 64):
script_option = '-s -f'
else:
script_option = '-s'

if script and not module.check_mode:
command = "%s -s -m %s %s -- %s" % (parted_exec, align_option, device, script)
command = "%s %s -m %s %s -- %s" % (parted_exec, script_option, align_option, device, script)
rc, out, err = module.run_command(command)

if rc != 0:
Expand Down