-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipx: Allow injected modules to add apps #6198
pipx: Allow injected modules to add apps #6198
Conversation
Add support for pipx inject's "--include-apps" parameter.
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I've added some first comments below.
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Ping @russoz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long time to review. LGTM.
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #6238 🤖 @patchback |
* pipx: Allow injected modules to add apps Add support for pipx inject's "--include-apps" parameter. * add changelog fragment * fix pipx test ("install_apps", not "include_apps") * fix pipx test -- add a second invocation for install_apps * Update changelogs/fragments/6198-pipx-inject-install-apps.yml Co-authored-by: Felix Fontein <[email protected]> * Update plugins/modules/pipx.py Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 6fa833f)
@darkrain42 thanks for your contribution! |
…o add apps (#6238) pipx: Allow injected modules to add apps (#6198) * pipx: Allow injected modules to add apps Add support for pipx inject's "--include-apps" parameter. * add changelog fragment * fix pipx test ("install_apps", not "include_apps") * fix pipx test -- add a second invocation for install_apps * Update changelogs/fragments/6198-pipx-inject-install-apps.yml Co-authored-by: Felix Fontein <[email protected]> * Update plugins/modules/pipx.py Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 6fa833f) Co-authored-by: Paul Aurich <[email protected]>
Add support for
pipx inject
's--include-apps
parameter.SUMMARY
Add support to the pipx module so that
state=inject
can cause pipx to include applications from the specified app into $PATH.For instance, I currently have an ansible install with ansible-lint injected, and I want ansible-lint in $PATH. I can achieve that manually, but I can't codify it (cleanly) in my ansible playbooks.
ISSUE TYPE
COMPONENT NAME
pipx
ADDITIONAL INFORMATION