Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6212/33093e9f backport][stable-6] pipx: document parameters supported with state=latest, and fix include_injected parameter #6266

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Mar 30, 2023

This is a backport of PR #6212 as merged into main (33093e9).

SUMMARY

Improve the pipx module so the documentation matches what attributes are allowed with which states.

  • Document which parameters are allowed with state=latest (everything supported with either state=install or state=upgrade)
  • Fix include_injected so that it works with state=upgrade and state=latest

This depends on #6198. Happy to keep it as a separate PR or fold it into that one.

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

pipx

ADDITIONAL INFORMATION

…e_injected parameter (#6212)

* pipx: Document parameters supported with state=latest

* pipx: Support "include_injected" with states "upgrade" and "latest"

- Contrary to documentation, "include_injected" doesn't appear to have
  worked with state=upgrade since it was introduced.
- Add support for include_injected with "latest", since "latest" is
  specified as being install+upgrade.

* Add changelog fragment

* Update plugins/modules/pipx.py

Co-authored-by: Felix Fontein <[email protected]>

* Update changelog fragment

Co-authored-by: Felix Fontein <[email protected]>

* pipx: Update to correct target release of community.general

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 33093e9)
@ansibullbot
Copy link
Collaborator

cc @russoz
click here for bot help

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug language module module new_contributor Help guide this first time contributor packaging plugins plugin (any type) labels Mar 30, 2023
@felixfontein felixfontein merged commit 6b0cc3c into stable-6 Mar 30, 2023
@felixfontein felixfontein deleted the patchback/backports/stable-6/33093e9f3e92d2facada017e9927c3303b56918f/pr-6212 branch March 30, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug language module module new_contributor Help guide this first time contributor packaging plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants