Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6198/6fa833fe backport][stable-6] pipx: Allow injected modules to add apps #6238

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Mar 26, 2023

This is a backport of PR #6198 as merged into main (6fa833f).

Add support for pipx inject's --include-apps parameter.

SUMMARY

Add support to the pipx module so that state=inject can cause pipx to include applications from the specified app into $PATH.

For instance, I currently have an ansible install with ansible-lint injected, and I want ansible-lint in $PATH. I can achieve that manually, but I can't codify it (cleanly) in my ansible playbooks.

pipx install --include-deps ansible
pipx inject ansible --include-apps ansible-lint[yamllint]
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

pipx

ADDITIONAL INFORMATION

* pipx: Allow injected modules to add apps

Add support for pipx inject's "--include-apps" parameter.

* add changelog fragment

* fix pipx test ("install_apps", not "include_apps")

* fix pipx test -- add a second invocation for install_apps

* Update changelogs/fragments/6198-pipx-inject-install-apps.yml

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/modules/pipx.py

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 6fa833f)
@ansibullbot
Copy link
Collaborator

cc @russoz
click here for bot help

@ansibullbot ansibullbot added backport feature This issue/PR relates to a feature request integration tests/integration language module module module_utils module_utils needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor packaging plugins plugin (any type) tests tests and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Mar 26, 2023
@felixfontein felixfontein merged commit 9cd3f37 into stable-6 Mar 26, 2023
@felixfontein felixfontein deleted the patchback/backports/stable-6/6fa833feed441a1b58585fd6ddf659aa73147558/pr-6198 branch March 26, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request integration tests/integration language module_utils module_utils module module new_contributor Help guide this first time contributor packaging plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants