Create aws_eks_fargate_profile module #941
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her action in progress before starting
…ommunity.aws into dev-eks_fargate_profile
|
@tjarra this PR contains the following merge commits: Please rebase your branch to remove these commits. |
ansibullbot
added
merge_commit
|
Build failed.
|
…ommunity.aws into dev-eks_fargate_profile
|
@tjarra this PR contains the following merge commits: Please rebase your branch to remove these commits. |
|
Build failed.
|
|
Build failed.
|
…tjarra/community.aws into dev-eks_fargate_profile" This reverts commit d87ecde, reversing changes made to de60583.
|
@tjarra This PR was evaluated as a potentially problematic PR for the following reasons:
Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: |
ansibullbot
added
the
needs_revision
|
I'm having problems with this PR, I'm going to close it and fix it locally. |
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 31, 2022
New module aws_eks_fargate_profile SUMMARY (this is a copy of #941 because i messed up my original branch) New Module - aws_eks_fargate_profile This create a new module to manage fargate profiles in EKS clusters. Requires: ansible-collections/amazon.aws#651 ISSUE TYPE New Module Pull Request COMPONENT NAME aws_eks_fargate_profile ADDITIONAL INFORMATION community.aws.aws_eks_fargate_profile - name: create Fargate Profile aws_eks_fargate_profile: name: 'my-profile' state: present cluster_name: 'my-eks-cluster' role_arn: 'arn:aws:iam::999999999999:role/eks-FargatePodExecutionRole' subnets: - subnet-aaaa1111 selectors: - namespace: 'test_nm' labels: label1: test wait: true tags: env: test foo: bar Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: None <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None>
patchback bot
pushed a commit
that referenced
this pull request
Mar 31, 2022
New module aws_eks_fargate_profile SUMMARY (this is a copy of #941 because i messed up my original branch) New Module - aws_eks_fargate_profile This create a new module to manage fargate profiles in EKS clusters. Requires: ansible-collections/amazon.aws#651 ISSUE TYPE New Module Pull Request COMPONENT NAME aws_eks_fargate_profile ADDITIONAL INFORMATION community.aws.aws_eks_fargate_profile - name: create Fargate Profile aws_eks_fargate_profile: name: 'my-profile' state: present cluster_name: 'my-eks-cluster' role_arn: 'arn:aws:iam::999999999999:role/eks-FargatePodExecutionRole' subnets: - subnet-aaaa1111 selectors: - namespace: 'test_nm' labels: label1: test wait: true tags: env: test foo: bar Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: None <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> (cherry picked from commit 719483f)
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
) rds_instance: disable aurora integration tests Follow up to a recent behaviour change, the Aurora clusters are created with engine_mode=serverless by default. When we try to add a new instance with rds_instance, we get the following errror: Unable to create DB instance: An error occurred (InvalidParameterValue) when calling the CreateDBInstance operation: Instances cannot be added to Aurora Serverless clusters. e.g: https://ansible.softwarefactory-project.io/zuul/build/f1f7cb085f0c4038b905a216a118c229/logs Address the problem, we will need to add the engine_mode parameter to rds_cluster through ansible-collections#941 and adjust the test-suite. This commit temporarily disable the aurora integration tests for now. Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
rds - add the engine_mode parameter Depends-On: ansible-collections#1185 Add a new engine_mode parameter to rds_cluster and also adjust the test-suite follow-up to some recent API changes: With the aurora engine, engine_mode default now on serverless. We cannot adjust the endpoint_port of a serverless cluster. aurora clusters are now encrypted by default (storage_encrypted) The new engine_mode parameter also allows us to re-enable the Aurora test of the rds_instance integration tests. Reviewed-by: Gonéri Le Bouder <[email protected]> Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
rds_cluster: split up the test target Depends-On: ansible-collections#941 Split up the test target to avoid the parallel execution. Reviewed-by: Alina Buzachis <None> Reviewed-by: Gonéri Le Bouder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
New Module - aws_eks_fargate_profile
This create a new module to manage fargate profiles in EKS clusters.
Requires: ansible-collections/amazon.aws#651
ISSUE TYPE
COMPONENT NAME
aws_eks_fargate_profile
ADDITIONAL INFORMATION
Example: