Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EKS Fargate Profile waiters #651

Conversation

tjarra
Copy link
Contributor

@tjarra tjarra commented Feb 2, 2022

SUMMARY

Add waiters for eks fargate profile to manage deleted and created states.
A PR will be done in community.aws to add a new module to manage the eks_fargate_profile resource that uses these waiters.

New module PR: ansible-collections/community.aws#942

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

waiter.py

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module_utils module_utils needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels Feb 2, 2022
@softwarefactory-project-zuul
Copy link
Contributor

@softwarefactory-project-zuul
Copy link
Contributor

@goneri
Copy link
Member

goneri commented Feb 3, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

@tjarra
Copy link
Contributor Author

tjarra commented Feb 3, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

@alinabuzachis
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link
Contributor

@alinabuzachis
Copy link
Collaborator

@tjarra Thank you for taking time to work on this. Can you please reference the PR the waiters are needed for?

@jillr jillr added mergeit Merge the PR (SoftwareFactory) and removed needs_triage labels Feb 22, 2022
@jillr
Copy link
Collaborator

jillr commented Feb 22, 2022

Thanks @tjarra!

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 35c27b8 into ansible-collections:main Feb 22, 2022
jatorcasso pushed a commit to jatorcasso/amazon.aws that referenced this pull request Mar 1, 2022
Add EKS Fargate Profile waiters

SUMMARY
Add waiters for eks fargate profile to manage deleted and created states.
A PR will be done in community.aws to add a new module to manage the eks_fargate_profile resource that uses these waiters.
New module PR: ansible-collections/community.aws#942
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
waiter.py

Reviewed-by: Jill R <None>
softwarefactory-project-zuul bot pushed a commit to ansible-collections/community.aws that referenced this pull request Mar 31, 2022
New module aws_eks_fargate_profile

SUMMARY
(this is a copy of #941 because i messed up my original branch)
New Module - aws_eks_fargate_profile
This create a new module to manage fargate profiles in EKS clusters.
Requires: ansible-collections/amazon.aws#651
ISSUE TYPE

New Module Pull Request

COMPONENT NAME
aws_eks_fargate_profile
ADDITIONAL INFORMATION
community.aws.aws_eks_fargate_profile
- name: create Fargate Profile 
  aws_eks_fargate_profile:
    name: 'my-profile'
    state: present
    cluster_name: 'my-eks-cluster'
    role_arn: 'arn:aws:iam::999999999999:role/eks-FargatePodExecutionRole'
    subnets:
        - subnet-aaaa1111
    selectors:
        - namespace: 'test_nm'
          labels:
              label1: test
    wait: true
    tags:
        env: test
        foo: bar

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: None <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Jill R <None>
patchback bot pushed a commit to ansible-collections/community.aws that referenced this pull request Mar 31, 2022
New module aws_eks_fargate_profile

SUMMARY
(this is a copy of #941 because i messed up my original branch)
New Module - aws_eks_fargate_profile
This create a new module to manage fargate profiles in EKS clusters.
Requires: ansible-collections/amazon.aws#651
ISSUE TYPE

New Module Pull Request

COMPONENT NAME
aws_eks_fargate_profile
ADDITIONAL INFORMATION
community.aws.aws_eks_fargate_profile
- name: create Fargate Profile
  aws_eks_fargate_profile:
    name: 'my-profile'
    state: present
    cluster_name: 'my-eks-cluster'
    role_arn: 'arn:aws:iam::999999999999:role/eks-FargatePodExecutionRole'
    subnets:
        - subnet-aaaa1111
    selectors:
        - namespace: 'test_nm'
          labels:
              label1: test
    wait: true
    tags:
        env: test
        foo: bar

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: None <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Jill R <None>
(cherry picked from commit 719483f)
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
New module aws_eks_fargate_profile

SUMMARY
(this is a copy of ansible-collections#941 because i messed up my original branch)
New Module - aws_eks_fargate_profile
This create a new module to manage fargate profiles in EKS clusters.
Requires: ansible-collections#651
ISSUE TYPE

New Module Pull Request

COMPONENT NAME
aws_eks_fargate_profile
ADDITIONAL INFORMATION
community.aws.aws_eks_fargate_profile
- name: create Fargate Profile 
  aws_eks_fargate_profile:
    name: 'my-profile'
    state: present
    cluster_name: 'my-eks-cluster'
    role_arn: 'arn:aws:iam::999999999999:role/eks-FargatePodExecutionRole'
    subnets:
        - subnet-aaaa1111
    selectors:
        - namespace: 'test_nm'
          labels:
              label1: test
    wait: true
    tags:
        env: test
        foo: bar

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: None <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Jill R <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
New module aws_eks_fargate_profile

SUMMARY
(this is a copy of ansible-collections#941 because i messed up my original branch)
New Module - aws_eks_fargate_profile
This create a new module to manage fargate profiles in EKS clusters.
Requires: ansible-collections#651
ISSUE TYPE

New Module Pull Request

COMPONENT NAME
aws_eks_fargate_profile
ADDITIONAL INFORMATION
community.aws.aws_eks_fargate_profile
- name: create Fargate Profile 
  aws_eks_fargate_profile:
    name: 'my-profile'
    state: present
    cluster_name: 'my-eks-cluster'
    role_arn: 'arn:aws:iam::999999999999:role/eks-FargatePodExecutionRole'
    subnets:
        - subnet-aaaa1111
    selectors:
        - namespace: 'test_nm'
          labels:
              label1: test
    wait: true
    tags:
        env: test
        foo: bar

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: None <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Jill R <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) module_utils module_utils new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants