Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1187/029333b3 backport][stable-2] ecs_service and ecs_service_info: add name and service aliases #1192

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jun 1, 2022

This is a backport of PR #1187 as merged into main (029333b).

SUMMARY

while ecs_service is using name for the service name parameter, ecs_service_info is using service for the same purpose.
this PR adds just aliases to both modules, to use the same parameter to address the ecs service name.

ref #1142

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
COMPONENT NAME

ecs_service
ecs_service_info

ecs_service and ecs_service_info: add name and service aliases

SUMMARY
while ecs_service is using name for the service name parameter, ecs_service_info is using service for the same purpose.
this PR adds just aliases to both modules, to use the same parameter to address the ecs service name.
ref #1142
ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request

COMPONENT NAME
ecs_service
ecs_service_info

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Mark Chappell <None>
(cherry picked from commit 029333b)
@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels Jun 1, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 4m 32s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 57s
✔️ ansible-test-sanity-docker-devel SUCCESS in 8m 59s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 44s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 10m 28s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 31s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 11s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 09s
✔️ ansible-test-splitter SUCCESS in 3m 10s
✔️ integration-community.aws-1 SUCCESS in 5m 21s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label Jun 2, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 5m 26s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 41s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 11s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 24s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 16m 42s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 57s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 14m 39s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 50s
✔️ ansible-test-splitter SUCCESS in 2m 23s
✔️ integration-community.aws-1 SUCCESS in 5m 42s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit f23fad2 into stable-2 Jun 2, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-2/029333b3a974c1f31c27b1a2e9e7a1399733d857/pr-1187 branch June 2, 2022 05:18
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
)

rds_instance: disable aurora integration tests

Follow up to a recent behaviour change, the Aurora clusters are created
with engine_mode=serverless by default. When we try
to add a new instance with rds_instance, we get the following errror:
Unable to create DB instance: An error occurred (InvalidParameterValue) when calling the CreateDBInstance operation: Instances cannot be added to Aurora Serverless clusters.

e.g: https://ansible.softwarefactory-project.io/zuul/build/f1f7cb085f0c4038b905a216a118c229/logs
Address the problem, we will need to add the engine_mode parameter to rds_cluster
through ansible-collections#941 and adjust
the test-suite.
This commit temporarily disable the aurora integration tests for now.

Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review mergeit Merge the PR (SoftwareFactory) module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants