Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rds_instance_snaphot to use handlers defined in rds.py #789

Conversation

alinabuzachis
Copy link
Contributor

@alinabuzachis alinabuzachis commented Nov 1, 2021

SUMMARY
  • Update module to use handlers defined in rds.py
  • Enable check_mode
  • Add integration tests

Depends-On: ansible-collections/amazon.aws#553
Also requires: mattclay/aws-terminator#185

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

rds_instance_snapshot

@alinabuzachis alinabuzachis changed the title Update module to use handlers defined in rds.py Update rds_instance_snaphot to use handlers defined in rds.py Nov 1, 2021
…s and enable check_mode

Signed-off-by: Alina Buzachis <[email protected]>
@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Nov 1, 2021
Signed-off-by: Alina Buzachis <[email protected]>
@alinabuzachis
Copy link
Contributor Author

recheck

Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
@alinabuzachis alinabuzachis force-pushed the rds_instance_snapshot branch from 2f27c7d to 372c067 Compare January 5, 2022 11:07
@alinabuzachis
Copy link
Contributor Author

recheck

@alinabuzachis
Copy link
Contributor Author

recheck

@alinabuzachis
Copy link
Contributor Author

recheck

@alinabuzachis
Copy link
Contributor Author

recheck

@alinabuzachis
Copy link
Contributor Author

recheck

@alinabuzachis alinabuzachis requested a review from jillr January 28, 2022 21:09
@alinabuzachis alinabuzachis requested review from markuman and tremble May 3, 2022 08:43
@alinabuzachis alinabuzachis force-pushed the rds_instance_snapshot branch from 75801b8 to f4e36ba Compare May 4, 2022 11:06
Signed-off-by: Alina Buzachis <[email protected]>
@alinabuzachis alinabuzachis force-pushed the rds_instance_snapshot branch from f4e36ba to 65ebdce Compare May 4, 2022 11:06
@github-actions
Copy link

github-actions bot commented May 4, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@alinabuzachis
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 4m 56s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 08s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 00s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 13s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 11m 36s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 10s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 43s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 08s
✔️ ansible-test-splitter SUCCESS in 3m 12s
✔️ integration-community.aws-1 SUCCESS in 28m 52s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@markuman markuman added the backport-3 PR should be backported to the stable-3 branch label May 6, 2022
Copy link
Contributor

@jatorcasso jatorcasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label May 9, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 6m 56s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 54s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 17s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 15s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 48s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 12m 39s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 50s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 42s
✔️ ansible-test-splitter SUCCESS in 3m 22s
✔️ integration-community.aws-1 SUCCESS in 26m 20s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 872f6e3 into ansible-collections:main May 9, 2022
@patchback
Copy link

patchback bot commented May 9, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/872f6e31ee822d09e62f2e24357a68e0387fa4e9/pr-789

Backported as #1139

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 9, 2022
Update rds_instance_snaphot to use handlers defined in rds.py

SUMMARY

Update module to use handlers defined in rds.py
Enable check_mode
Add integration tests

Depends-On: ansible-collections/amazon.aws#553
Also requires: mattclay/aws-terminator#185

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

rds_instance_snapshot

Reviewed-by: Jill R <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Joseph Torcasso <None>
(cherry picked from commit 872f6e3)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 9, 2022
…1139)

[PR #789/872f6e31 backport][stable-3] Update rds_instance_snaphot to use handlers defined in rds.py

This is a backport of PR #789 as merged into main (872f6e3).
SUMMARY


Update module to use handlers defined in rds.py
Enable check_mode
Add integration tests

Depends-On: ansible-collections/amazon.aws#553
Also requires: mattclay/aws-terminator#185

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

rds_instance_snapshot

Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…e-collections#789)

Update rds_instance_snaphot to use handlers defined in rds.py

SUMMARY

Update module to use handlers defined in rds.py
Enable check_mode
Add integration tests

Depends-On: ansible-collections/amazon.aws#553
Also requires: mattclay/aws-terminator#185

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

rds_instance_snapshot

Reviewed-by: Jill R <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Joseph Torcasso <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@872f6e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3 PR should be backported to the stable-3 branch community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants