-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rds_instance_snaphot to use handlers defined in rds.py #789
Update rds_instance_snaphot to use handlers defined in rds.py #789
Conversation
…s and enable check_mode Signed-off-by: Alina Buzachis <[email protected]>
fbccb45
to
85949c9
Compare
Signed-off-by: Alina Buzachis <[email protected]>
recheck |
Signed-off-by: Alina Buzachis <[email protected]>
Build failed.
|
Signed-off-by: Alina Buzachis <[email protected]>
2f27c7d
to
372c067
Compare
recheck |
recheck |
Build failed.
|
recheck |
recheck |
recheck |
Build succeeded.
|
75801b8
to
f4e36ba
Compare
Signed-off-by: Alina Buzachis <[email protected]>
f4e36ba
to
65ebdce
Compare
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #1139 🤖 @patchback |
Update rds_instance_snaphot to use handlers defined in rds.py SUMMARY Update module to use handlers defined in rds.py Enable check_mode Add integration tests Depends-On: ansible-collections/amazon.aws#553 Also requires: mattclay/aws-terminator#185 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Joseph Torcasso <None> (cherry picked from commit 872f6e3)
…1139) [PR #789/872f6e31 backport][stable-3] Update rds_instance_snaphot to use handlers defined in rds.py This is a backport of PR #789 as merged into main (872f6e3). SUMMARY Update module to use handlers defined in rds.py Enable check_mode Add integration tests Depends-On: ansible-collections/amazon.aws#553 Also requires: mattclay/aws-terminator#185 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Alina Buzachis <None>
…e-collections#789) Update rds_instance_snaphot to use handlers defined in rds.py SUMMARY Update module to use handlers defined in rds.py Enable check_mode Add integration tests Depends-On: ansible-collections/amazon.aws#553 Also requires: mattclay/aws-terminator#185 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Joseph Torcasso <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@872f6e3
SUMMARY
Depends-On: ansible-collections/amazon.aws#553
Also requires: mattclay/aws-terminator#185
ISSUE TYPE
COMPONENT NAME
rds_instance_snapshot