-
Notifications
You must be signed in to change notification settings - Fork 398
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update rds_instance_snaphot to use handlers defined in rds.py (#789)
Update rds_instance_snaphot to use handlers defined in rds.py SUMMARY Update module to use handlers defined in rds.py Enable check_mode Add integration tests Depends-On: ansible-collections/amazon.aws#553 Also requires: mattclay/aws-terminator#185 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Joseph Torcasso <None> (cherry picked from commit 872f6e3)
- Loading branch information
1 parent
b993c7a
commit 6120275
Showing
6 changed files
with
452 additions
and
108 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
minor_changes: | ||
- rds_instance_snapshot - update module to use handlers defined in module_utils/rds.py (https://github.com/ansible-collections/community.aws/pull/789). | ||
- rds_instance_snapshot - add ``check_mode`` (https://github.com/ansible-collections/community.aws/pull/789). | ||
- rds_instance_snapshot - add integration tests (https://github.com/ansible-collections/community.aws/pull/789). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
cloud/aws | ||
|
||
rds_snapshot_info |
14 changes: 14 additions & 0 deletions
14
tests/integration/targets/rds_instance_snapshot/defaults/main.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
--- | ||
# defaults file for rds_instance_snapshot | ||
|
||
# Create RDS instance | ||
instance_id: 'ansible-test-instance-{{ resource_prefix }}' | ||
username: 'testrdsusername' | ||
password: 'test-rds_password' | ||
db_instance_class: db.t3.micro | ||
allocated_storage: 10 | ||
engine: 'mariadb' | ||
mariadb_engine_version: 10.3.31 | ||
|
||
# Create snapshot | ||
snapshot_id: 'ansible-test-instance-snapshot-{{ resource_prefix }}' |
Oops, something went wrong.