[PR #789/872f6e31 backport][stable-3] Update rds_instance_snaphot to use handlers defined in rds.py #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
Update rds_instance_snaphot to use handlers defined in rds.py SUMMARY Update module to use handlers defined in rds.py Enable check_mode Add integration tests Depends-On: ansible-collections/amazon.aws#553 Also requires: mattclay/aws-terminator#185 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Joseph Torcasso <None> (cherry picked from commit 872f6e3)
alinabuzachis
approved these changes
May 9, 2022
ansibullbot
added
community_review
feature
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-3/872f6e31ee822d09e62f2e24357a68e0387fa4e9/pr-789
branch
abikouo
added a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…ble-collections#1139) move get_s3_connection, reduce complexity and increase coverage SUMMARY get_s3_connection is duplicated into modules s3_object and s3_object_info, the goal of this pull request is to move to a single place, reduce code complexity and increase coverage ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None> Reviewed-by: Gonéri Le Bouder <[email protected]> Reviewed-by: Bikouo Aubin <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #789 as merged into main (872f6e3).
SUMMARY
Depends-On: ansible-collections/amazon.aws#553
Also requires: mattclay/aws-terminator#185
ISSUE TYPE
COMPONENT NAME
rds_instance_snapshot