Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate ec2_vpc_endpoint* modules and tests #672

Merged
merged 4 commits into from
Aug 27, 2021
Merged

Migrate ec2_vpc_endpoint* modules and tests #672

merged 4 commits into from
Aug 27, 2021

Conversation

alinabuzachis
Copy link
Contributor

@alinabuzachis alinabuzachis commented Aug 3, 2021 •
edited
Loading

Depends-On: ansible-collections/amazon.aws#435

Remove ec2_vpc_endpoint* modules and tests
These modules have been migrated to amazon.aws
Update runtime.yml with redirects to that collection
Update ignore files

@ansibullbot
Copy link

cc @Etherdaemon @jillr @markuman @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added docs integration tests/integration module module needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage plugins plugin (any type) tests tests labels Aug 3, 2021
@alinabuzachis alinabuzachis force-pushed the promote_ec2_vpc_endpoint branch 2 times, most recently from c3740e0 to 339e97e Compare August 4, 2021 09:09
@ansibullbot ansibullbot added community_review and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Aug 4, 2021
@alinabuzachis alinabuzachis force-pushed the promote_ec2_vpc_endpoint branch 2 times, most recently from 2022176 to fe3d699 Compare August 6, 2021 08:33
@alinabuzachis
Copy link
Contributor Author

recheck

@alinabuzachis alinabuzachis force-pushed the promote_ec2_vpc_endpoint branch 4 times, most recently from 767c9e3 to d662331 Compare August 13, 2021 13:32
@alinabuzachis
Copy link
Contributor Author

recheck

1 similar comment
@goneri
Copy link
Member

goneri commented Aug 23, 2021

recheck

@goneri
Copy link
Member

goneri commented Aug 23, 2021

I see this error in the logs of ansible-test-sanity-docker-stable-2.9: ERROR: tests/sanity/ignore-2.9.txt:18:1: File 'plugins/modules/ec2_vpc_endpoint_info.py' does not exist

@alinabuzachis alinabuzachis force-pushed the promote_ec2_vpc_endpoint branch 2 times, most recently from cd4de54 to efc698f Compare August 23, 2021 14:23
@alinabuzachis
Copy link
Contributor Author

recheck

2 similar comments
@goneri
Copy link
Member

goneri commented Aug 23, 2021

recheck

@goneri
Copy link
Member

goneri commented Aug 23, 2021

recheck

@alinabuzachis alinabuzachis force-pushed the promote_ec2_vpc_endpoint branch from efc698f to d8a1a6d Compare August 23, 2021 19:49
@alinabuzachis alinabuzachis changed the title DNM Migrate ec2_vpc_endpoint* modules and tests Migrate ec2_vpc_endpoint* modules and tests Aug 24, 2021
@alinabuzachis alinabuzachis force-pushed the promote_ec2_vpc_endpoint branch 2 times, most recently from 7f7466f to df6df7c Compare August 26, 2021 13:23
@alinabuzachis alinabuzachis requested a review from tremble August 26, 2021 13:26
@tremble
Copy link
Contributor

tremble commented Aug 27, 2021

ansible-collections/amazon.aws#435 has been merged. gating.

@tremble tremble added the gate label Aug 27, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tremble tremble force-pushed the promote_ec2_vpc_endpoint branch from df6df7c to bd88904 Compare August 27, 2021 11:42
@ansible-zuul ansible-zuul bot removed the gate label Aug 27, 2021
@tremble
Copy link
Contributor

tremble commented Aug 27, 2021

rebased

@tremble tremble added gate and removed gate labels Aug 27, 2021
@ansible-zuul ansible-zuul bot merged commit 4c17572 into ansible-collections:main Aug 27, 2021
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this pull request Mar 14, 2022
@alinabuzachis
While migrating ec2_vpc_route_table and ec2_vpc_route_table (ansible-…
486a850 
…collections#672)

from community.aws to amazon.aws, we forget to delete the modules from the community.aws collection after the promotion.
As of now, the modules within community.aws have not received any new updates, so we can remove them without backporting anything.

Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this pull request Mar 14, 2022
@alinabuzachis
While migrating ec2_vpc_route_table and ec2_vpc_route_table_info (ans…
ea62bba 
…ible-collections#672)

from community.aws to amazon.aws, we forget to delete the modules from the community.aws collection after the promotion.
As of now, the modules within community.aws have not received any new updates, so we can remove them without backporting anything.

Signed-off-by: Alina Buzachis <[email protected]>
@alinabuzachis alinabuzachis mentioned this pull request Mar 14, 2022
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Apr 5, 2022
@alinabuzachis
While migrating ec2_vpc_route_table and ec2_vpc_route_table_info (#672)…
b9c89dd 
… (#987)

Delete ec2_vpc_route_table* since already promoted 

While migrating ec2_vpc_route_table and ec2_vpc_route_table_info (#672) from community.aws to amazon.aws, we forget to delete the modules from the community.aws collection after the promotion. As of now, the modules within community.aws have not received any new updates, so we can remove them without backporting anything.
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Jill R <None>
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@alinabuzachis
Fix TypeError: 'NoneType' object is not subscriptable (ansible-collec…
395b730 
…tions#672)

ec2_vpc_igw: fix 'NoneType' object is not subscriptable

SUMMARY

ec2_vpc_igw: fix 'NoneType' object is not subscriptable

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ec2_vpc_igw
ADDITIONAL INFORMATION

Reviewed-by: Jill R <None>
Reviewed-by: Joseph Torcasso <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@alinabuzachis
While migrating ec2_vpc_route_table and ec2_vpc_route_table_info (ans…
613ed51 
…ible-collections/community.aws#672) (ansible-collections#987)

Delete ec2_vpc_route_table* since already promoted 

While migrating ec2_vpc_route_table and ec2_vpc_route_table_info (ansible-collections#672) from community.aws to amazon.aws, we forget to delete the modules from the community.aws collection after the promotion. As of now, the modules within community.aws have not received any new updates, so we can remove them without backporting anything.
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Jill R <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@alinabuzachis @abikouo
While migrating ec2_vpc_route_table and ec2_vpc_route_table_info (ans…
e206284 
…ible-collections/community.aws#672) (ansible-collections#987)

Delete ec2_vpc_route_table* since already promoted 

While migrating ec2_vpc_route_table and ec2_vpc_route_table_info (ansible-collections#672) from community.aws to amazon.aws, we forget to delete the modules from the community.aws collection after the promotion. As of now, the modules within community.aws have not received any new updates, so we can remove them without backporting anything.
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Jill R <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@tremble tremble tremble approved these changes

@jillr jillr Awaiting requested review from jillr

@goneri goneri Awaiting requested review from goneri

Assignees
No one assigned
Labels
community_review docs integration tests/integration module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alinabuzachis @ansibullbot @goneri @tremble