Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete ec2_vpc_route_table* since already promoted #987

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Delete ec2_vpc_route_table* since already promoted #987

merged 1 commit into from
Apr 5, 2022

Conversation

alinabuzachis
Copy link
Contributor

While migrating ec2_vpc_route_table and ec2_vpc_route_table_info (#672) from community.aws to amazon.aws, we forget to delete the modules from the community.aws collection after the promotion. As of now, the modules within community.aws have not received any new updates, so we can remove them without backporting anything.

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@alinabuzachis
While migrating ec2_vpc_route_table and ec2_vpc_route_table_info (ans…
ea62bba 
…ible-collections#672)

from community.aws to amazon.aws, we forget to delete the modules from the community.aws collection after the promotion.
As of now, the modules within community.aws have not received any new updates, so we can remove them without backporting anything.

Signed-off-by: Alina Buzachis <[email protected]>
@alinabuzachis alinabuzachis requested a review from jillr March 14, 2022 14:03
@ansibullbot
Copy link

cc @jillr @markuman @s-hertel @tremble
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review docs integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Mar 14, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@markuman
Copy link
Member

recheck

@markuman markuman added the backport-3 PR should be backported to the stable-3 branch label Mar 14, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

jatorcasso
jatorcasso approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@jatorcasso jatorcasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests were actually failing occasionally due to a race conditions so lets get this one merged

@jillr jillr added the mergeit Merge the PR (SoftwareFactory) label Apr 1, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@jatorcasso jatorcasso mentioned this pull request Apr 1, 2022
Merged
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@markuman
Copy link
Member

markuman commented Apr 2, 2022

regate

@alinabuzachis
Copy link
Contributor Author

@markuman Since this is a breaking change is this something we want to backport to stable-3?

@markuman
Copy link
Member

markuman commented Apr 2, 2022

@markuman Since this is a breaking change is this something we want to backport to stable-3?

Oh, yeah. You are right!

@markuman markuman removed the backport-3 PR should be backported to the stable-3 branch label Apr 2, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@markuman
Copy link
Member

markuman commented Apr 2, 2022

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@markuman
Copy link
Member

markuman commented Apr 2, 2022

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@jatorcasso
Copy link
Contributor

regate

@goneri goneri closed this Apr 5, 2022
@goneri goneri reopened this Apr 5, 2022
@goneri
Copy link
Member

goneri commented Apr 5, 2022

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b9c89dd into ansible-collections:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jatorcasso jatorcasso jatorcasso approved these changes

@jillr jillr jillr approved these changes

@markuman markuman markuman approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review docs integration tests/integration mergeit Merge the PR (SoftwareFactory) module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alinabuzachis @ansibullbot @markuman @jatorcasso @goneri @jillr