inventory/aws_rds: fix a recent regression #987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put back the `self._read_config_data(path)` call that was removed during 4780226. Without this call we end up with an empty `aws_rds` in the output if the inventory file is empty. To reproduce: ``` cd tests/integration/targets/inventory_aws_rds ANSIBLE_INVENTORY_ENABLED=amazon.aws.aws_rds ANSIBLE_INVENTORY=test.aws_rds.yml ansible-playbook playbooks/test_invalid_aws_rds_inventory_config.yml -vvvv ``` ``` ok: [127.0.0.1] => { "groups": { "all": [], "aws_rds": [], <--- the unexpected key "ungrouped": [] } ```
ansibullbot
added
community_review
inventory
|
I'm not so sure about this one. I need more time to understand what's actually going on. |
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ible-collections/community.aws#672) (ansible-collections#987) Delete ec2_vpc_route_table* since already promoted While migrating ec2_vpc_route_table and ec2_vpc_route_table_info (ansible-collections#672) from community.aws to amazon.aws, we forget to delete the modules from the community.aws collection after the promotion. As of now, the modules within community.aws have not received any new updates, so we can remove them without backporting anything. SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ible-collections/community.aws#672) (ansible-collections#987) Delete ec2_vpc_route_table* since already promoted While migrating ec2_vpc_route_table and ec2_vpc_route_table_info (ansible-collections#672) from community.aws to amazon.aws, we forget to delete the modules from the community.aws collection after the promotion. As of now, the modules within community.aws have not received any new updates, so we can remove them without backporting anything. SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…ible-collections/community.aws#672) (ansible-collections#987) Delete ec2_vpc_route_table* since already promoted While migrating ec2_vpc_route_table and ec2_vpc_route_table_info (ansible-collections#672) from community.aws to amazon.aws, we forget to delete the modules from the community.aws collection after the promotion. As of now, the modules within community.aws have not received any new updates, so we can remove them without backporting anything. SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put back the
self._read_config_data(path)call that was removed during4780226.
Without this call we end up with an empty
aws_rdsin the output ifthe inventory file is empty.
To reproduce: