-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update module using module_utils/cloudfront_facts.py #1596
update module using module_utils/cloudfront_facts.py #1596
Conversation
This change depends on a change that failed to merge. |
recheck |
d53b182
to
625f7d4
Compare
When running the cloudfront_distribution tests to test the terminator PR, they pass but there are 2 distributions remaining in the CI AWS account that are not automatically deleted by the test suite. Please ensure that all resources created by the tests are removed by the tests. |
3433d0f
to
839036b
Compare
only the second cloudfront distribution was not deleted, I have updated the test. Could you please validate once again in a clean environment? Thanks |
recheck |
I saw this failure locally, too, but when I re-ran all the tests passed. Something here seems a little flaky. |
839036b
to
920e331
Compare
920e331
to
a38e0f8
Compare
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Depends-On: ansible-collections/amazon.aws#1265
SUMMARY
update cloudfront_* modules, fix some bugs and add integration tests
ISSUE TYPE