Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminator policies for CloudFront modules #245

Merged
merged 4 commits into from
Dec 1, 2022

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Nov 15, 2022

@gravesm
Copy link
Collaborator

gravesm commented Nov 15, 2022

Could you add the link in the description to the PR in the amazon collection that this change is for?

@abikouo
Copy link
Contributor Author

abikouo commented Nov 15, 2022

Could you add the link in the description to the PR in the amazon collection that this change is for?

PR has been updated accordingly

aws/policy/paas.yaml Outdated Show resolved Hide resolved
aws/policy/paas.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies I missed some of this on my previous look.
The policies are in paas.yml but the terminator class is in application-services.py - these should be in the same grouping in both places to avoid confusion.

There may be a bug in the plugin code, the integration tests fail at:

TASK [cloudfront_distribution : Update the distribution with tags] **************************************************************************************************************************************************************************
task path: /root/ansible_collections/community/aws/tests/output/.tmp/integration/cloudfront_distribution-5u0dnd61-ÅÑŚÌβŁÈ/tests/integration/targets/cloudfront_distribution/tasks/main.yml:34
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: TypeError: get_distribution() got an unexpected keyword argument 'id'
fatal: [testhost]: FAILED! => {"boto3_version": "1.18.0", "botocore_version": "1.21.0", "changed": false, "msg": "Error validating distribution_id from alias, aliases and caller reference: get_distribution() got an unexpected keyword argument 'id'", "resource_actions": []}

I have the policies deployed to the dev area of the CI account (with all of the policies moved to a ResourceUnrestricted Sid for the sake of testing). You can test your PR locally against the CI account like ansible-test integration -vv cloudfront_distribution --remote-stage dev --docker with the deployed dev policy. We can figure out the resource restrictions in another iteration.

aws/policy/paas.yaml Outdated Show resolved Hide resolved
aws/terminator/application_services.py Outdated Show resolved Hide resolved
aws/terminator/application_services.py Outdated Show resolved Hide resolved
@abikouo abikouo requested a review from jillr November 22, 2022 12:01
@abikouo abikouo force-pushed the cloudfront_xx branch 2 times, most recently from dff8a3e to d2cc744 Compare November 22, 2022 12:41
aws/policy/paas.yaml Outdated Show resolved Hide resolved
aws/terminator/paas.py Outdated Show resolved Hide resolved
aws/policy/paas.yaml Outdated Show resolved Hide resolved
@abikouo abikouo requested review from gravesm and jillr and removed request for jillr and gravesm November 29, 2022 15:50
@gravesm gravesm merged commit 6c06097 into mattclay:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants