Refactor module_utils/cloudfront_facts and add unit tests #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
abikouo
force-pushed
the
cloudfront_facts_unit_tests
branch
from
d6ef31a to
d894aaa
Compare
ansibullbot
added
community_review
feature
|
recheck |
goneri
reviewed
Nov 14, 2022
| if 'Items' in item['Aliases']: | ||
| aliases = item['Aliases']['Items'] | ||
| for alias in aliases: | ||
| keyed_list.update({alias: item}) |
There was a problem hiding this comment.
I've a bit confused by the code of this function. I understand it's the original code and you've just moved it. We're ignoring all the aliases but the last one. It sounds wrong.
There was a problem hiding this comment.
I don't why you are saying that it sounds wrong, basically the code extend the item so that we can find element using either distribution id or one its aliases
|
recheck |
|
check ondemand |
goneri
approved these changes
Nov 15, 2022
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
Feb 1, 2023
update module using module_utils/cloudfront_facts.py Depends-On: ansible-collections/amazon.aws#1265 SUMMARY update cloudfront_* modules, fix some bugs and add integration tests ISSUE TYPE Feature Pull Request Reviewed-by: Alina Buzachis <None> Reviewed-by: Bikouo Aubin <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
… support (ansible-collections#1265) [5.0.0] iam_server_cerificate - complete deprecation cycles SUMMARY fixes: ansible-collections#1257 In ansible-collections#735 we deprecated passing filenames and prepared to switch the default value of dup_ok to True. This PR completes the deprecation cycle (1 release late) ISSUE TYPE Feature Pull Request COMPONENT NAME iam_server_certificate ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
abikouo
added a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ions#1596) update module using module_utils/cloudfront_facts.py Depends-On: ansible-collections#1265 SUMMARY update cloudfront_* modules, fix some bugs and add integration tests ISSUE TYPE Feature Pull Request Reviewed-by: Alina Buzachis <None> Reviewed-by: Bikouo Aubin <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
… support (ansible-collections#1265) [5.0.0] iam_server_cerificate - complete deprecation cycles SUMMARY fixes: ansible-collections#1257 In ansible-collections#735 we deprecated passing filenames and prepared to switch the default value of dup_ok to True. This PR completes the deprecation cycle (1 release late) ISSUE TYPE Feature Pull Request COMPONENT NAME iam_server_certificate ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
abikouo
added a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ions#1596) update module using module_utils/cloudfront_facts.py Depends-On: ansible-collections#1265 SUMMARY update cloudfront_* modules, fix some bugs and add integration tests ISSUE TYPE Feature Pull Request Reviewed-by: Alina Buzachis <None> Reviewed-by: Bikouo Aubin <None>
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 13, 2023
…ansible-collections#1265) [5.0.0] iam_server_cerificate - complete deprecation cycles SUMMARY fixes: ansible-collections#1257 In ansible-collections#735 we deprecated passing filenames and prepared to switch the default value of dup_ok to True. This PR completes the deprecation cycle (1 release late) ISSUE TYPE Feature Pull Request COMPONENT NAME iam_server_certificate ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@058ecff
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 13, 2023
…ansible-collections#1265) [5.0.0] iam_server_cerificate - complete deprecation cycles SUMMARY fixes: ansible-collections#1257 In ansible-collections#735 we deprecated passing filenames and prepared to switch the default value of dup_ok to True. This PR completes the deprecation cycle (1 release late) ISSUE TYPE Feature Pull Request COMPONENT NAME iam_server_certificate ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@058ecff
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
… support (ansible-collections#1265) [5.0.0] iam_server_cerificate - complete deprecation cycles SUMMARY fixes: ansible-collections#1257 In ansible-collections#735 we deprecated passing filenames and prepared to switch the default value of dup_ok to True. This PR completes the deprecation cycle (1 release late) ISSUE TYPE Feature Pull Request COMPONENT NAME iam_server_certificate ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: ansible/ansible-zuul-jobs#1695
SUMMARY
refactor module_utils/cloudfront_facts.py and unit tests
ISSUE TYPE