[PR #694/7cf0e505 backport][stable-3] feat: Add S3 bucket owner enforcement #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
feat: Add S3 bucket owner enforcement
SUMMARY
AWS finally supports the ability to enforce object ownership such that the owner of the bucket owns all objects. This adds support for that.
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
s3_bucket
ADDITIONAL INFORMATION
---
- hosts: localhost
tasks:
- s3_bucket:
name: tyler-test-123
state: present
- s3_bucket:
name: tyler-test-123
object_ownership: BucketOwnerEnforced
state: present
- s3_bucket:
name: tyler-test-123
state: absent
- s3_bucket:
name: tyler-test-123
object_ownership: BucketOwnerEnforced
state: present
- s3_bucket:
name: tyler-test-123
state: absent
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>
(cherry picked from commit 7cf0e50)
ansibullbot
added
community_review
feature
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-3/7cf0e505d4a601793aa3a187abbda4448cb79234/pr-694
branch
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Deprecate passing file names to the iam_server_certificate module SUMMARY iam_server_certificate currently accepts file names (or content) in the cert, chain_cert and key options. Since the module directly uses open(). This will perform a 'remote' lookup with unexpected results for relative file paths. Encourage the use of lookups so that the behaviour will at least be predictable. ISSUE TYPE Feature Pull Request COMPONENT NAME iam_server_certificate ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
… support (ansible-collections#1265) [5.0.0] iam_server_cerificate - complete deprecation cycles SUMMARY fixes: ansible-collections#1257 In ansible-collections#735 we deprecated passing filenames and prepared to switch the default value of dup_ok to True. This PR completes the deprecation cycle (1 release late) ISSUE TYPE Feature Pull Request COMPONENT NAME iam_server_certificate ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
… support (ansible-collections#1265) [5.0.0] iam_server_cerificate - complete deprecation cycles SUMMARY fixes: ansible-collections#1257 In ansible-collections#735 we deprecated passing filenames and prepared to switch the default value of dup_ok to True. This PR completes the deprecation cycle (1 release late) ISSUE TYPE Feature Pull Request COMPONENT NAME iam_server_certificate ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 13, 2023
…ansible-collections#1265) [5.0.0] iam_server_cerificate - complete deprecation cycles SUMMARY fixes: ansible-collections#1257 In ansible-collections#735 we deprecated passing filenames and prepared to switch the default value of dup_ok to True. This PR completes the deprecation cycle (1 release late) ISSUE TYPE Feature Pull Request COMPONENT NAME iam_server_certificate ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@058ecff
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 13, 2023
…ansible-collections#1265) [5.0.0] iam_server_cerificate - complete deprecation cycles SUMMARY fixes: ansible-collections#1257 In ansible-collections#735 we deprecated passing filenames and prepared to switch the default value of dup_ok to True. This PR completes the deprecation cycle (1 release late) ISSUE TYPE Feature Pull Request COMPONENT NAME iam_server_certificate ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@058ecff
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Deprecate passing file names to the iam_server_certificate module SUMMARY iam_server_certificate currently accepts file names (or content) in the cert, chain_cert and key options. Since the module directly uses open(). This will perform a 'remote' lookup with unexpected results for relative file paths. Encourage the use of lookups so that the behaviour will at least be predictable. ISSUE TYPE Feature Pull Request COMPONENT NAME iam_server_certificate ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
… support (ansible-collections#1265) [5.0.0] iam_server_cerificate - complete deprecation cycles SUMMARY fixes: ansible-collections#1257 In ansible-collections#735 we deprecated passing filenames and prepared to switch the default value of dup_ok to True. This PR completes the deprecation cycle (1 release late) ISSUE TYPE Feature Pull Request COMPONENT NAME iam_server_certificate ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #694 as merged into main (7cf0e50).
SUMMARY
AWS finally supports the ability to enforce object ownership such that the owner of the bucket owns all objects. This adds support for that.
ISSUE TYPE
COMPONENT NAME
s3_bucket
ADDITIONAL INFORMATION