Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-4] iam_policy - add support for diff mode #1376

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jul 29, 2022

SUMMARY

Manual back-port of (#1375)

Adds support for diff mode
renames policies to policy_names so that in future we can return the policies (outside of the diff) too.
Attempts to handle AccessDenied more cleanly

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

iam_policy

ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz

iam_policy - add support for diff mode

SUMMARY
fixes: ansible-collections#560

Adds support for diff mode
renames policies to policy_names so that in future we can return the policies (outside of the diff) too.
Attempts to handle AccessDenied more cleanly

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_policy
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
Reviewed-by: Markus Bergholz <[email protected]>
@tremble tremble requested a review from markuman July 29, 2022 12:07
@github-actions
Copy link

github-actions bot commented Jul 29, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Jul 29, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 49s
✔️ build-ansible-collection SUCCESS in 5m 45s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 13s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 15s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 38s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 26s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 12s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 8m 07s
✔️ ansible-test-splitter SUCCESS in 2m 51s
✔️ integration-community.aws-1 SUCCESS in 5m 30s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jul 29, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 3m 58s
✔️ build-ansible-collection SUCCESS in 4m 56s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 19s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 08s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 23s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 03s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 05s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 46s
✔️ ansible-test-splitter SUCCESS in 2m 32s
✔️ integration-community.aws-1 SUCCESS in 6m 29s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit eced0bb into ansible-collections:stable-4 Jul 29, 2022
@tremble tremble deleted the backports/stable-4/pr-1345 branch September 9, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants