Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support diff mode for IAM policies #560

Closed
celik0311 opened this issue Apr 29, 2021 · 5 comments · Fixed by #1375
Closed

support diff mode for IAM policies #560

celik0311 opened this issue Apr 29, 2021 · 5 comments · Fixed by #1375
Labels
feature This issue/PR relates to a feature request module module plugins plugin (any type) waiting_on_contributor Needs help. Feel free to engage to get things unblocked

Comments

@celik0311
Copy link

SUMMARY

It would be nice to have support for diff mode for IAM policy changes. This would be useful for seeing which changes would be applied.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

iam_policy

ADDITIONAL INFORMATION


      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
      



  

  @ansibullbot





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          
Files identified in the description:



If these files are inaccurate, please update the component name section of the description or use the !component bot command.


click here for bot help


      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @ansibullbot





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          
cc @jillr @s-hertel @sbj-ss @tremble @wimnat

click here for bot help


      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @ansibullbot
ansibullbot




            added
      

  feature

  This issue/PR relates to a feature request

      

  module

  module

      

  needs_triage


      

  plugins

  plugin (any type)

  labels


      Apr 29, 2021

    

  



    

    

      
    

    


      

          @goneri
goneri




            added
      

  waiting_on_contributor

  Needs help. Feel free to engage to get things unblocked

    and removed
      

  needs_triage


  labels


      Jun 15, 2021

    

  








      

  
      



  

  @Razique





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

      

      
            Razique
  

      

      

      commented


        Apr 1, 2022


      
    


  





      


        


  
    

      
          
@celik0311

Ansible already has a diff mode:


ansible-playbook foo.yml --check --diff --limit foo.example.com


In diff mode, Ansible provides before-and-after comparisons. Modules that support diff mode display detailed information.

Does that help for what you are trying to accomplish?

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @ansibullbot





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          
cc @markuman

click here for bot help


      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @markuman





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

      

      
            markuman
  

      

      

      commented


        Apr 1, 2022


      
  •

  

    
      

        
          edited
          
        
        
      

    
    
      
        
      Loading

      
    
  



    


  





      


        


  
    

      
          
Imo diff mode is currently only supported by


    

  • community.aws.route53
    • 

  • community.aws.ec2_scaling_policy
    • 



So yes, it's a nice must have feature and would be verry helpful for several modules.


@celik0311 Are you willing to help here and implement diff mode for community.aws.iam_policy .

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
          


  
    
  
  

    
  alinabuzachis 

      pushed a commit
        to alinabuzachis/community.aws
      that referenced
      this issue

    
      May 25, 2022
    
    

      


  

    

      


  

      
        @jrglynn2
  





      

        
          Fix for Issue ansible-collections#560 Add example for searching volum…
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          c303e04
        
      

    

  

    

      
…es by EC2 instance ID (ansible-collections#561)

Fix for Issue ansible-collections#560  Add example for searching volumes by EC2 instance ID

SUMMARY
Add example for Searching volumes based on EC2 Instance ID - "state: list" functionality from ec2_vol
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
ec2_vol_info
ADDITIONAL INFORMATION
fixes: ansible-collections#560

Reviewed-by: Mark Chappell <None>
Reviewed-by: None <None>

    




    

  




  

  

    
  


  

      

    @tremble
tremble



    mentioned this issue
    
      Jul 29, 2022
    





  


  

      
   Merged

  







  




    

    


  


  
    
  
  

    
  softwarefactory-project-zuul bot

      pushed a commit
      that referenced
      this issue

    
      Jul 29, 2022
    
    

      


  

    

      


  

      
        @tremble
  





      

        
          iam_policy - add support for diff mode (#1375)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          1ac84c3
        
      

    

  

    

      
iam_policy - add support for diff mode

SUMMARY
fixes: #560

Adds support for diff mode
renames policies to policy_names so that in future we can return the policies (outside of the diff) too.
Attempts to handle AccessDenied more cleanly

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_policy
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
Reviewed-by: Markus Bergholz <[email protected]>

    




    

  




  


  
    
  
  

    
  tremble 

      added a commit
        to tremble/community.aws
      that referenced
      this issue

    
      Jul 29, 2022
    
    

      


  

    

      


  

      
        @tremble
  





      

        
          iam_policy - add support for diff mode (ansible-collections#1375)
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          d655412
        
      

    

  

    

      
iam_policy - add support for diff mode

SUMMARY
fixes: ansible-collections#560

Adds support for diff mode
renames policies to policy_names so that in future we can return the policies (outside of the diff) too.
Attempts to handle AccessDenied more cleanly

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_policy
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
Reviewed-by: Markus Bergholz <[email protected]>

    




    

  




  

  

    
  


  

      

    @renovate
renovate
bot


    mentioned this issue
    
      Aug 8, 2022
    





  


  

      
   Merged

  





  
  

      
        
      
      

  
    
    
  


    1 task
  





  




  


  
    
  
  

    
  abikouo 

      pushed a commit
        to abikouo/community.aws
      that referenced
      this issue

    
      Oct 24, 2023
    
    

      


  

    

      


  

      
        @tremble
      
        @goneri
  





      

        
          iam_policy - add support for diff mode (ansible-collections#1375)
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          4ba58c0
        
      

    

  

    

      
iam_policy - add support for diff mode

SUMMARY
fixes: ansible-collections#560

Adds support for diff mode
renames policies to policy_names so that in future we can return the policies (outside of the diff) too.
Attempts to handle AccessDenied more cleanly

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_policy
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
Reviewed-by: Markus Bergholz <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@1ac84c3

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    feature

  This issue/PR relates to a feature request
  

    module

  module
  

    plugins

  plugin (any type)
  

    waiting_on_contributor

  Needs help. Feel free to engage to get things unblocked








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




          
  
Successfully merging a pull request may close this issue.





    


  
          
      iam_policy - add support for diff mode

    
      tremble/community.aws
    





    
  




      

    

  
      

  

    

      5 participants
    

    

        
          @goneri 
        
          @Razique 
        
          @markuman 
        
          @celik0311 
        
          @ansibullbot