iam_policy - add support for diff mode #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
commented
Jul 29, 2022
| @@ -35,7 +35,6 @@ | |||
| policy_json: | |||
| description: | |||
| - A properly json formatted policy as string. | |||
| - See U(https://github.com/ansible/ansible/issues/7005#issuecomment-42894813) on how to use it properly. | |||
There was a problem hiding this comment.
Note for the reader, we switched to the "JSON" type prior to Ansible 2.10 which makes this reference about Ansible mangling templated JSON strings moot.
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
feature
markuman
approved these changes
Jul 29, 2022
markuman
added
mergeit
Backport to stable-4: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 1ac84c3 on top of patchback/backports/stable-4/1ac84c305b3853477cb78af35aa89902ac98f1fb/pr-1375 Backporting merged PR #1375 into main
🤖 @patchback |
tremble
added a commit
to tremble/community.aws
that referenced
this pull request
Jul 29, 2022
iam_policy - add support for diff mode SUMMARY fixes: ansible-collections#560 Adds support for diff mode renames policies to policy_names so that in future we can return the policies (outside of the diff) too. Attempts to handle AccessDenied more cleanly ISSUE TYPE Feature Pull Request COMPONENT NAME iam_policy ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <[email protected]>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jul 29, 2022
[stable-4] iam_policy - add support for diff mode SUMMARY Manual back-port of (#1375) Adds support for diff mode renames policies to policy_names so that in future we can return the policies (outside of the diff) too. Attempts to handle AccessDenied more cleanly ISSUE TYPE Feature Pull Request COMPONENT NAME iam_policy ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz Reviewed-by: Alina Buzachis <None>
1 task
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
iam_policy - add support for diff mode SUMMARY fixes: ansible-collections#560 Adds support for diff mode renames policies to policy_names so that in future we can return the policies (outside of the diff) too. Attempts to handle AccessDenied more cleanly ISSUE TYPE Feature Pull Request COMPONENT NAME iam_policy ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@1ac84c3
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Black-en plugins/plugin_utils SUMMARY Minor linting related changes to plugins/plugin_utils ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/plugin_utils ADDITIONAL INFORMATION This code hasn't been released yet. Reviewed-by: Jill R Reviewed-by: Alina Buzachis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
fixes: #560
policiestopolicy_namesso that in future we can return the policies (outside of the diff) too.ISSUE TYPE
COMPONENT NAME
iam_policy
ADDITIONAL INFORMATION