[PR #340/c9b1b02e backport][stable-4] ecs_service - support setting deployment controller on a service #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
ecs_service - support setting deployment controller on a service
SUMMARY
Support setting platform version to 1.4.0 (LATEST is 1.3.0) and deployment controller.
The first allows access to new 1.4.0 features. The second change allows you to create a service that can be controlled with Code Deploy.
Example:
- name: create a Fargate service
community.aws.ecs_service:
state: present
name: "my-service"
cluster: "my-cluster"
platform_version: 1.4.0
task_definition: "my-task"
desired_count: "1"
launch_type: FARGATE
scheduling_strategy: REPLICA
deployment_controller:
type: CODE_DEPLOY
load_balancers:
- targetGroupArn: "arn:..."
containerName: example
containerPort: 80
network_configuration:
subnets:
- "{{vpc_zone_a.subnet.id}}"
- "{{vpc_zone_b.subnet.id}}"
security_groups:
- "sg-example"
assign_public_ip: true
This fixes #338.
ISSUE TYPE
Feature Pull Request
Reviewed-by: Jill R <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Markus Bergholz <[email protected]>
(cherry picked from commit c9b1b02)
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
feature
tremble
approved these changes
Jul 4, 2022
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-4/c9b1b02eb78c62eeccb3a96a597ece8e7a3d6038/pr-340
branch
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…ters (ansible-collections#1303) Add support to AnsibleAWSModule.client to override the default parameters Depends-On: ansible-collections#1635 SUMMARY When refactoring the inventory plugins it was helpful to be able to override region, however looking at the S3 code, it's also helpful to be able to override other things too. Pull this in as a small change while I work on the rest of it. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/modules.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Refactor S3 connection code SUMMARY Builds upon ansible-collections#1303 making the S3 code closer to the rest of our connection code. ISSUE TYPE Feature Pull Request COMPONENT NAME s3_object s3_object_info s3_bucket ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #340 as merged into main (c9b1b02).
SUMMARY
Support setting platform version to 1.4.0 (LATEST is 1.3.0) and deployment controller.
The first allows access to new 1.4.0 features. The second change allows you to create a service that can be controlled with Code Deploy.
Example:
This fixes #338.
ISSUE TYPE