ecs_service - support setting deployment controller on a service #340

berenddeboer · 2020-12-23T00:17:13Z

SUMMARY

Support setting platform version to 1.4.0 (LATEST is 1.3.0) and deployment controller.

The first allows access to new 1.4.0 features. The second change allows you to create a service that can be controlled with Code Deploy.

Example:

  - name: create a Fargate service
    community.aws.ecs_service:
      state: present
      name: "my-service"
      cluster: "my-cluster"
      platform_version: 1.4.0
      task_definition: "my-task"
      desired_count: "1"
      launch_type: FARGATE
      scheduling_strategy: REPLICA
      deployment_controller:
        type: CODE_DEPLOY
      load_balancers:
        - targetGroupArn: "arn:..."
          containerName: example
          containerPort: 80
      network_configuration:
        subnets:
          - "{{vpc_zone_a.subnet.id}}"
          - "{{vpc_zone_b.subnet.id}}"
        security_groups:
          - "sg-example"
        assign_public_ip: true

This fixes #338.

ISSUE TYPE

Feature Pull Request

ansibullbot · 2021-01-13T00:25:42Z

cc @Java1Guy @jillr @kaczynskid @s-hertel @tremble @wimnat @zacblazic
click here for bot help

alinabuzachis · 2021-02-24T14:10:32Z

Hi @berenddeboer, thank you for your contribution. The platform_version has been added in #353. Would you like to work with the other PR #353 to have both features integrated. Otherwise, the merge of the first PR will raise a conflict with the second one.

jillr

Thanks for this PR @berenddeboer, could you also please add a changelog fragment?

plugins/modules/ecs_service.py

tremble

Thanks for taking the time to raise this PR.

In addition to the changelog, I'm not sure that always adding the two parameters is the right behaviour.

tremble · 2021-03-29T11:46:03Z

plugins/modules/ecs_service.py

                       placement_constraints, placement_strategy, health_check_grace_period_seconds,
                       network_configuration, service_registries, launch_type, scheduling_strategy):

        params = dict(
            cluster=cluster_name,
            serviceName=service_name,
+            platformVersion=platform_version,


This is going to cause an exception when platform_version isn't set (it'll default to None, which Boto3 doesn't like.)

tremble · 2021-03-29T11:48:03Z

plugins/modules/ecs_service.py

            taskDefinition=task_definition,
            loadBalancers=load_balancers,
            clientToken=client_token,
            role=role,
+            deploymentController=deployment_controller,


I'm not sure if it's possible to change existing services but blindly setting this here would add new behaviour wiping out any manual configuration of a deployment controller (people sometimes work around modules not having features by using the AWS cli to tweak things.)

plugins/modules/ecs_service.py

berenddeboer · 2021-04-04T21:03:01Z

Hi @berenddeboer, thank you for your contribution. The platform_version has been added in #353. Would you like to work with the other PR #353 to have both features integrated. Otherwise, the merge of the first PR will raise a conflict with the second one.

It seems #353 is good to go, so if that gets merged verse, I can resolve any conflicts.

ansibullbot · 2021-04-04T21:11:13Z

@berenddeboer this PR contains the following merge commits:

7074613

Please rebase your branch to remove these commits.

click here for bot help

…ns#340) test/s3: keep the bucket name length under control (<63 characters) Reviewed-by: https://github.com/apps/ansible-zuul

github-actions · 2022-07-03T15:13:06Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

ansibullbot · 2022-07-03T15:18:31Z

cc @markuman
click here for bot help

softwarefactory-project-zuul · 2022-07-03T15:26:12Z

Build failed.

softwarefactory-project-zuul · 2022-07-03T16:19:58Z

Build failed.

tremble

I've trimmed this back to just the deployment controller. For the sake of clearing things out I think we skip the integration test requirement.

Unsupported ecs_service tests pass

softwarefactory-project-zuul · 2022-07-03T18:56:20Z

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 06s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 15s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 26s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 41s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 35s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 51s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 00s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 10s
✔️ ansible-test-splitter SUCCESS in 2m 29s
✔️ integration-community.aws-1 SUCCESS in 5m 56s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

softwarefactory-project-zuul · 2022-07-04T07:54:23Z

Build succeeded (gate pipeline).

patchback · 2022-07-04T07:54:28Z

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/c9b1b02eb78c62eeccb3a96a597ece8e7a3d6038/pr-340

Backported as #1303

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

ecs_service - support setting deployment controller on a service SUMMARY Support setting platform version to 1.4.0 (LATEST is 1.3.0) and deployment controller. The first allows access to new 1.4.0 features. The second change allows you to create a service that can be controlled with Code Deploy. Example: - name: create a Fargate service community.aws.ecs_service: state: present name: "my-service" cluster: "my-cluster" platform_version: 1.4.0 task_definition: "my-task" desired_count: "1" launch_type: FARGATE scheduling_strategy: REPLICA deployment_controller: type: CODE_DEPLOY load_balancers: - targetGroupArn: "arn:..." containerName: example containerPort: 80 network_configuration: subnets: - "{{vpc_zone_a.subnet.id}}" - "{{vpc_zone_b.subnet.id}}" security_groups: - "sg-example" assign_public_ip: true This fixes #338. ISSUE TYPE Feature Pull Request Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit c9b1b02)

… (#1303) [PR #340/c9b1b02e backport][stable-4] ecs_service - support setting deployment controller on a service This is a backport of PR #340 as merged into main (c9b1b02). SUMMARY Support setting platform version to 1.4.0 (LATEST is 1.3.0) and deployment controller. The first allows access to new 1.4.0 features. The second change allows you to create a service that can be controlled with Code Deploy. Example: - name: create a Fargate service community.aws.ecs_service: state: present name: "my-service" cluster: "my-cluster" platform_version: 1.4.0 task_definition: "my-task" desired_count: "1" launch_type: FARGATE scheduling_strategy: REPLICA deployment_controller: type: CODE_DEPLOY load_balancers: - targetGroupArn: "arn:..." containerName: example containerPort: 80 network_configuration: subnets: - "{{vpc_zone_a.subnet.id}}" - "{{vpc_zone_b.subnet.id}}" security_groups: - "sg-example" assign_public_ip: true This fixes #338. ISSUE TYPE Feature Pull Request Reviewed-by: Mark Chappell <None>

ansibullbot added feature This issue/PR relates to a feature request module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels Jan 13, 2021

alinabuzachis removed the needs_triage label Feb 24, 2021

jillr reviewed Mar 19, 2021

View reviewed changes

plugins/modules/ecs_service.py Show resolved Hide resolved

tremble requested changes Mar 29, 2021

View reviewed changes

plugins/modules/ecs_service.py Show resolved Hide resolved

plugins/modules/ecs_service.py Outdated Show resolved Hide resolved

tremble mentioned this pull request Mar 29, 2021

Add platform to ecs service #353

Merged

ansibullbot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Apr 4, 2021

berenddeboer added 2 commits July 3, 2022 17:08

feat: ecs_service support setting deployment controller

4c4d944

Add changelog fragment

7f0b51d

tremble force-pushed the support-new-ecs-fargate-functionality branch from 7074613 to 7f0b51d Compare July 3, 2022 15:08

lint

fefeac7

tremble changed the title ~~specify platform version and deployment controller on a service~~ ecs_service - support setting deployment controller on a service Jul 3, 2022

Minor fixups

eeec0ab

tremble requested a review from jillr July 3, 2022 18:38

tremble approved these changes Jul 3, 2022

View reviewed changes

tremble requested review from markuman, alinabuzachis and jatorcasso July 3, 2022 18:40

markuman added the backport-4 PR should be backported to the stable-4 branch label Jul 4, 2022

markuman approved these changes Jul 4, 2022

View reviewed changes

tremble added the mergeit Merge the PR (SoftwareFactory) label Jul 4, 2022

softwarefactory-project-zuul bot merged commit c9b1b02 into ansible-collections:main Jul 4, 2022

patchback bot mentioned this pull request Jul 4, 2022

[PR #340/c9b1b02e backport][stable-4] ecs_service - support setting deployment controller on a service #1303

Merged

fortinetps mentioned this pull request Jul 9, 2022

ec2_transit_gateway error with gateway has no "Description" key #68

Closed

renovate bot mentioned this pull request Aug 8, 2022

chore(deps): update dependency community.aws to v4.1.1 linxside/ansible-ee#44

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ecs_service - support setting deployment controller on a service #340

ecs_service - support setting deployment controller on a service #340

berenddeboer commented Dec 23, 2020

ansibullbot commented Jan 13, 2021

alinabuzachis commented Feb 24, 2021

jillr left a comment

tremble left a comment

tremble Mar 29, 2021

tremble Mar 29, 2021

berenddeboer commented Apr 4, 2021

ansibullbot commented Apr 4, 2021

github-actions bot commented Jul 3, 2022 •

edited

Loading

ansibullbot commented Jul 3, 2022

softwarefactory-project-zuul bot commented Jul 3, 2022

softwarefactory-project-zuul bot commented Jul 3, 2022

tremble left a comment

softwarefactory-project-zuul bot commented Jul 3, 2022

softwarefactory-project-zuul bot commented Jul 4, 2022

patchback bot commented Jul 4, 2022 •

edited

Loading

ecs_service - support setting deployment controller on a service #340

ecs_service - support setting deployment controller on a service #340

Conversation

berenddeboer commented Dec 23, 2020

SUMMARY

ISSUE TYPE

ansibullbot commented Jan 13, 2021

alinabuzachis commented Feb 24, 2021

jillr left a comment

Choose a reason for hiding this comment

tremble left a comment

Choose a reason for hiding this comment

tremble Mar 29, 2021

Choose a reason for hiding this comment

tremble Mar 29, 2021

Choose a reason for hiding this comment

berenddeboer commented Apr 4, 2021

ansibullbot commented Apr 4, 2021

github-actions bot commented Jul 3, 2022 • edited Loading

Docs Build 📝

ansibullbot commented Jul 3, 2022

softwarefactory-project-zuul bot commented Jul 3, 2022

softwarefactory-project-zuul bot commented Jul 3, 2022

tremble left a comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Jul 3, 2022

softwarefactory-project-zuul bot commented Jul 4, 2022

patchback bot commented Jul 4, 2022 • edited Loading

Backport to stable-4: 💚 backport PR created

github-actions bot commented Jul 3, 2022 •

edited

Loading

patchback bot commented Jul 4, 2022 •

edited

Loading