Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable networkfirewall_rule_group integration tests #1635

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jan 2, 2023

SUMMARY

Tests seem broken due to some kind of idempotency issue

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

networkfirewall_rule_group

ADDITIONAL INFORMATION

@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration plugins plugin (any type) small_patch Hopefully easy to review tests tests labels Jan 2, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 14s
✔️ build-ansible-collection SUCCESS in 5m 10s
✔️ ansible-test-sanity-docker-devel SUCCESS in 8m 48s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 26s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 28s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 12m 32s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 29s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 54s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 42s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 58s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 08s
✔️ ansible-test-changelog SUCCESS in 2m 23s
✔️ ansible-test-splitter SUCCESS in 2m 30s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit a00fa25 into ansible-collections:main Jan 2, 2023
softwarefactory-project-zuul bot pushed a commit to ansible-collections/amazon.aws that referenced this pull request Jan 2, 2023
…ters (#1303)

Add support to AnsibleAWSModule.client to override the default parameters

Depends-On: ansible-collections/community.aws#1635
SUMMARY
When refactoring the inventory plugins it was helpful to be able to override region, however looking at the S3 code, it's also helpful to be able to override other things too.  Pull this in as a small change while I work on the rest of it.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/module_utils/modules.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
@tremble tremble deleted the issues/1634/disable branch February 15, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) plugins plugin (any type) small_patch Hopefully easy to review tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants