Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare 3.4.0 #1249

Merged
merged 4 commits into from
Jun 23, 2022
Merged

Prepare 3.4.0 #1249

merged 4 commits into from
Jun 23, 2022

Conversation

jatorcasso
Copy link
Contributor

@jatorcasso jatorcasso commented Jun 23, 2022 •
edited
Loading

Depends-On: #1252

SUMMARY

Run add_docs, generate changelog, and update galaxy.yml for 3.4.0 collection release

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

galaxy.yml
docs/
changelog.rst

@ansibullbot

This comment was marked as resolved.

Sign in to view
@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage labels Jun 23, 2022
@softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul

This comment was marked as resolved.

Sign in to view
@softwarefactory-project-zuul

This comment was marked as resolved.

Sign in to view
@ansibullbot ansibullbot added community_review and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jun 23, 2022
@softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

❌ ansible-galaxy-importer FAILURE in 5m 15s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 57s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 17s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 12m 08s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 13s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 14s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 14s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 19s

@jatorcasso jatorcasso added the mergeit Merge the PR (SoftwareFactory) label Jun 23, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

❌ ansible-galaxy-importer FAILURE in 4m 08s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 53s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 10s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 48s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 57s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 46s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 59s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 8m 16s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit df75191 into ansible-collections:stable-3 Jun 23, 2022
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@tremble
Fix ec2_metadata_facts integration test (ansible-collections#1249)
aed3f77 
Fix ec2_metadata_facts integration test

SUMMARY
With ansible-collections#1214 security_group now validates the rules its passed, requiring a "source" be passed (SG/CIDR).  Previously it just dropped the rule on the floor.  This has however broken the ec2_metadata_facts integration test
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_metadata_facts
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis left review comments

@markuman markuman markuman approved these changes

@tremble tremble tremble approved these changes

@jillr jillr Awaiting requested review from jillr

@mandar242 mandar242 Awaiting requested review from mandar242

Assignees
No one assigned
Labels
community_review docs feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) needs_triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jatorcasso @ansibullbot @tremble @markuman @alinabuzachis