Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3] Fixup short description for aws_acm #1252

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 23, 2022

SUMMARY

Fixup short description for aws_acm
partial backport from #1185

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

plugins/modules/aws_acm.py

ADDITIONAL INFORMATION

> (as opposed to >-) results in a weird extra new line in the generated docs

@tremble tremble requested a review from markuman June 23, 2022 13:35
@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review docs module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) small_patch Hopefully easy to review labels Jun 23, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 5m 02s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 43s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 20s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 42s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 19s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 07s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 26s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 04s
✔️ ansible-test-splitter SUCCESS in 2m 35s
✔️ integration-community.aws-1 SUCCESS in 8m 19s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 23, 2022
@tremble tremble mentioned this pull request Jun 23, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 4m 41s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 48s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 52s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 14s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 13m 19s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 46s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 26s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 01s
✔️ ansible-test-splitter SUCCESS in 2m 28s
✔️ integration-community.aws-1 SUCCESS in 7m 04s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit efb4010 into ansible-collections:stable-3 Jun 23, 2022
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 23, 2022
Prepare 3.4.0

Depends-On: #1252
SUMMARY
Run add_docs, generate changelog, and update galaxy.yml for 3.4.0 collection release
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
galaxy.yml
docs/
changelog.rst

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Joseph Torcasso <None>
@tremble tremble deleted the backports/stable-3/aws_acm_description branch July 7, 2022 19:26
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
ec2_ami_info/tests: add unit-tests

SUMMARY


Add the unit-test coverage of the ec2_ami_info module.
break up list_ec2_images to move ec2_client.describe_image_attribute and ec2_client.describe_images to separate methods.
Add separate method to build request arguments dict
Do not pass module when we can use an exception to handle the API failures
Refactor ec2_ami_info module


COMPONENT NAME

ec2_ami_info

Reviewed-by: Bikouo Aubin <None>
Reviewed-by: Gonéri Le Bouder <[email protected]>
Reviewed-by: Mandar Kulkarni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review docs mergeit Merge the PR (SoftwareFactory) module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) small_patch Hopefully easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants