-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable-3] Fixup short description for aws_acm #1252
Merged
softwarefactory-project-zuul
merged 1 commit into
ansible-collections:stable-3
from
tremble:backports/stable-3/aws_acm_description
Jun 23, 2022
Merged
[stable-3] Fixup short description for aws_acm #1252
softwarefactory-project-zuul
merged 1 commit into
ansible-collections:stable-3
from
tremble:backports/stable-3/aws_acm_description
Jun 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinabuzachis
approved these changes
Jun 23, 2022
ansibullbot
added
community_review
docs
module
module
needs_triage
owner_pr
PR created by owner/maintainer
plugins
plugin (any type)
small_patch
Hopefully easy to review
labels
Jun 23, 2022
Merged
softwarefactory-project-zuul
bot
merged commit Jun 23, 2022
efb4010
into
ansible-collections:stable-3
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jun 23, 2022
Prepare 3.4.0 Depends-On: #1252 SUMMARY Run add_docs, generate changelog, and update galaxy.yml for 3.4.0 collection release ISSUE TYPE Feature Pull Request COMPONENT NAME galaxy.yml docs/ changelog.rst Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Joseph Torcasso <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
ec2_ami_info/tests: add unit-tests SUMMARY Add the unit-test coverage of the ec2_ami_info module. break up list_ec2_images to move ec2_client.describe_image_attribute and ec2_client.describe_images to separate methods. Add separate method to build request arguments dict Do not pass module when we can use an exception to handle the API failures Refactor ec2_ami_info module COMPONENT NAME ec2_ami_info Reviewed-by: Bikouo Aubin <None> Reviewed-by: Gonéri Le Bouder <[email protected]> Reviewed-by: Mandar Kulkarni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community_review
docs
mergeit
Merge the PR (SoftwareFactory)
module
module
needs_triage
owner_pr
PR created by owner/maintainer
plugins
plugin (any type)
small_patch
Hopefully easy to review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixup short description for aws_acm
partial backport from #1185
ISSUE TYPE
COMPONENT NAME
plugins/modules/aws_acm.py
ADDITIONAL INFORMATION
>
(as opposed to>-
) results in a weird extra new line in the generated docs