[stable-3] wafv2_ip_set - fix bugs with changing description #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s#1211) wafv2_ip_set - fix bugs with changing description SUMMARY updating just the description didn't update the changed state ISSUE TYPE Bugfix Pull Request COMPONENT NAME wafv2_ip_set ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]>
ansibullbot
added
bug
tremble
changed the title
alinabuzachis
approved these changes
Jun 7, 2022
softwarefactory-project-zuul
bot
merged commit 7a5ece4
into
ansible-collections:stable-3
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #1228 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 7, 2022
[stable-3] wafv2_ip_set - fix bugs with changing description Manual backport of #1211 SUMMARY Updating just the description didn't update the changed state ISSUE TYPE Bugfix Pull Request COMPONENT NAME wafv2_ip_set ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz Reviewed-by: Alina Buzachis <None> (cherry picked from commit 7a5ece4)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jun 8, 2022
) [PR #1214/7a5ece48 backport][stable-2] wafv2_ip_set - fix bugs with changing description This is a backport of PR #1214 as merged into stable-3 (7a5ece4). Manual backport of #1211 SUMMARY Updating just the description didn't update the changed state ISSUE TYPE Bugfix Pull Request COMPONENT NAME wafv2_ip_set ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz Reviewed-by: Markus Bergholz <[email protected]>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…ible-collections#1214) ec2_security_group - Move validation for rules into the arg_spec SUMMARY The bulk of the current rule validation can be better handled by arg_spec parameter validation. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_security_group ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
ec2_security_group - refacter get_target_from_rule() SUMMARY refacter get_target_from_rule to bring down the complexity score Builds on top of ansible-collections#1214 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_security_group ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Fix ec2_metadata_facts integration test SUMMARY With ansible-collections#1214 security_group now validates the rules its passed, requiring a "source" be passed (SG/CIDR). Previously it just dropped the rule on the floor. This has however broken the ec2_metadata_facts integration test ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_metadata_facts ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #1211
SUMMARY
Updating just the description didn't update the changed state
ISSUE TYPE
COMPONENT NAME
wafv2_ip_set
ADDITIONAL INFORMATION
Reviewed-by: Markus Bergholz