backport-3: ecs_service deployment_circuit_breaker #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecs_service - document circuit breaker feature SUMMARY Fixes #921 This feature works with the existing code, so this was mainly adding documentation, examples, and an integration test. ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION The deployment circuit breaker is part of the deployment configuration dictionary, which is already snake<=>camel cased. Thus the existing code was handling 99% of the feature, we just added some type validation, documentation, examples, and an integration test. - community.aws.ecs_service: state: present name: test-service cluster: test-cluster task_definition: test-task-definition desired_count: 3 deployment_configuration: deployment_circuit_breaker: enable: True rollback: True Reviewed-by: Mark Chappell <None>
alinabuzachis
approved these changes
Jun 7, 2022
|
@markuman This PR contains |
ansibullbot
added
bug
fix assert of deploymentCircuitBreaker SUMMARY fix broken ecs_cluster integration test of #1215 ISSUE TYPE COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
ansibullbot
added
community_review
and removed
needs_revision
softwarefactory-project-zuul
bot
merged commit c630be0
into
ansible-collections:stable-3
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…e reuse (ansible-collections#1227) Move botocore version validation into module_utils.botocore for future reuse Depends-On: ansible-collections#1246 SUMMARY In preparation for ansible-collections#1225 move the SDK version validation pieces over into module_utils.botocore ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/botocore.py plugins/module_utils/core.py plugins/module_utils/exceptions.py plugins/module_utils/modules.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…collections#1248) Refacter docs fragments and synchronize modules and plugins SUMMARY Move some of our docs fragments about to better reflect what they're for and the fact that we now have our own "amazon.aws..." namespace we can use. Synchronises the modules and plugins docs fragments (as far as possible) Updates plugin docs fragments to reflect the previously announced env variable deprecations Note: the amazon.aws.common.plugins fragment will necessitate some changes to the inventory and lookup plugins before use. (See also ansible-collections#1225). However, those changes will then bring them in line with the other modules ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/docs_fragments ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Refacter lookup plugins Depends-On: ansible-collections#1248 SUMMARY Refacters the lookup plugins to use common code for common boto3/botocore operations ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/lookup/aws_account_attribute.py plugins/lookup/aws_secret.py plugins/lookup/aws_ssm.py plugins/module_utils/botocore.py plugins/module_utils/core.py plugins/module_utils/exceptions.py plugins/module_utils/modules.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
manual backport of
there is no
version_added, because the module already supports this feature. it was just undocumented.ISSUE TYPE
COMPONENT NAME
ecs_service
ADDITIONAL INFORMATION