ecs_service - document circuit breaker feature #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With integration test.
karcadia
changed the title
ansibullbot
added
community_review
feature
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
There was already a deploymentConfiguration block in the delete_service return object doc.
tremble
approved these changes
Jun 4, 2022
|
Thanks for this PR. LGTM. |
|
The integration test is failing |
This was referenced Jun 7, 2022
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jun 7, 2022
backport-3: ecs_service deployment_circuit_breaker SUMMARY manual backport of #1215 #1217 there is no version_added, because the module already supports this feature. it was just undocumented. ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jun 7, 2022
backport-2: ecs_service deployment_circuit_breaker SUMMARY manual backport of #1215 #1217 there is no version_added, because the module already supports this feature. it was just undocumented. ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #921
This feature works with the existing code, so this was mainly adding documentation, examples, and an integration test.
ISSUE TYPE
COMPONENT NAME
ecs_service
ADDITIONAL INFORMATION
The deployment circuit breaker is part of the deployment configuration dictionary, which is already snake<=>camel cased. Thus the existing code was handling 99% of the feature, we just added some type validation, documentation, examples, and an integration test.