Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community.aws 2.6.0 release prep #1246

Closed
wants to merge 1 commit into from
Closed

community.aws 2.6.0 release prep #1246

wants to merge 1 commit into from

Conversation

mandar242
Copy link
Contributor

SUMMARY

community.aws 2.6.0 release

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

community.aws collection

@ansibullbot
Copy link

@mandar242 This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage labels Jun 22, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

❌ ansible-galaxy-importer FAILURE in 5m 09s (non-voting)
✔️ build-ansible-collection SUCCESS in 8m 09s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 09s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 41s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 40s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 12m 17s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 25s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 17s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 21m 32s

markuman
markuman reviewed Jun 22, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
markuman
markuman reviewed Jun 22, 2022
View reviewed changes
CHANGELOG.rst Outdated Show resolved Hide resolved
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

❌ ansible-galaxy-importer FAILURE in 3m 47s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 02s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 58s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 17s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 57s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 18s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 10s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 48s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 8m 08s

@mandar242 mandar242 requested a review from markuman June 22, 2022 18:14
@ansibullbot ansibullbot added docs tests tests and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jun 22, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

❌ ansible-galaxy-importer FAILURE in 3m 36s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 44s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 05s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 29s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 38s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 38s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 45s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 12s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 00s

@mandar242 mandar242 added the mergeit Merge the PR (SoftwareFactory) label Jun 22, 2022
tremble
tremble reviewed Jun 22, 2022
View reviewed changes
CHANGELOG.rst Show resolved Hide resolved
@mandar242 mandar242 closed this Jun 22, 2022
@mandar242 mandar242 mentioned this pull request Jun 22, 2022
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 22, 2022
@mandar242
Prep 2.6.0 release, Run add_docs, generate changelog, add release_sum…
5d6b100 
…mary changelog (#1247)

community.aws 2.6.0 release prep

SUMMARY

Reopened from #1246 to abort merging without making requested code change after applying mergeit label.
community.aws 2.6.0 release

ISSUE TYPE


Bugfix Pull Request
Docs Pull Request

COMPONENT NAME

community.aws collection

Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@tremble
Move exceptions (ansible-collections#1246)
8ff6340 
Move exceptions into their own python module

SUMMARY
Move base/core exceptions into their own python module
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
module_utils
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@tremble
Move botocore version validation into module_utils.botocore for futur…
c4be395 
…e reuse (ansible-collections#1227)

Move botocore version validation into module_utils.botocore for future reuse

Depends-On: ansible-collections#1246
SUMMARY
In preparation for ansible-collections#1225 move the SDK version validation pieces over into module_utils.botocore
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/module_utils/botocore.py
plugins/module_utils/core.py
plugins/module_utils/exceptions.py
plugins/module_utils/modules.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@tremble
Refacter get_aws_connection_info / get_aws_region (ansible-collection…
25e8e35 
…s#1231)

Refacter get_aws_connection_info / get_aws_region

Depends-On: ansible-collections#1246
SUMMARY
Splits up the logic for get_aws_region and get_aws_connection_info so that it can be reused by non-module plugins.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/module_utils/botocore.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble left review comments

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@jillr jillr jillr approved these changes

@markuman markuman markuman approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review docs mergeit Merge the PR (SoftwareFactory) needs_triage tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mandar242 @ansibullbot @tremble @markuman @jillr @alinabuzachis