Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stable-2: Backport milestone sanity fixes and additional sanity fixes #1124

Conversation

jatorcasso
Copy link
Contributor

@jatorcasso jatorcasso commented May 6, 2022

Reviewed-by: Alina Buzachis
Reviewed-by: Jill R
(cherry picked from commit c1d47dd)

SUMMARY
  • Manually backport milestone sanity fixes to stable-2.
  • Sanity fixes for aws_ssm
  • ignore pylint unnecessary list comprehension for iam
ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME
  • cloudfront_distribution
  • ecs_taskdefinition
  • elb_application_lb
  • rds_option_group
  • aws_ssm
  • iam

@ansibullbot
Copy link

@jatorcasso jatorcasso changed the title Backport stable-2: Add missing elements option to type: list that did not specify stable-2: Backport milestone sanity fixes and add aws_ssm sanity fix May 6, 2022
@ansibullbot ansibullbot added the connection connection plugin label May 6, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

ansible-galaxy-importer FAILURE in 4m 38s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 04s
ansible-test-sanity-docker-devel FAILURE in 11m 44s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 9m 13s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 11m 24s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 36s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 25s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 12s
✔️ ansible-test-splitter SUCCESS in 3m 01s
✔️ integration-community.aws-1 SUCCESS in 16m 10s
✔️ integration-community.aws-2 SUCCESS in 8m 04s
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@jatorcasso jatorcasso changed the title stable-2: Backport milestone sanity fixes and add aws_ssm sanity fix stable-2: Backport milestone sanity fixes and additional sanity fixes May 6, 2022
@ansibullbot ansibullbot added new_module New module new_plugin New plugin tests tests labels May 6, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

ansible-galaxy-importer FAILURE in 5m 29s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 20s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 43s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 09s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 00s
ansible-test-sanity-docker-stable-2.11 FAILURE in 10m 15s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 31s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 38s
✔️ ansible-test-splitter SUCCESS in 3m 44s
✔️ integration-community.aws-1 SUCCESS in 16m 00s
✔️ integration-community.aws-2 SUCCESS in 7m 49s
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@markuman markuman requested a review from alinabuzachis May 6, 2022 05:28
@jatorcasso jatorcasso force-pushed the patchback/backports/stable-2/sanity-fixes-milestone branch from ade3c88 to 6b322c9 Compare May 6, 2022 05:34
@softwarefactory-project-zuul
Copy link
Contributor

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/ansible-collections/community.aws for 1124,6b322c9a2750ec0d38bc3cdf7a30e5dcc5b42e18

@jatorcasso jatorcasso marked this pull request as draft May 6, 2022 05:39
@ansibullbot ansibullbot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review new_module New module new_plugin New plugin labels May 6, 2022
jatorcasso and others added 3 commits May 6, 2022 01:45
…ible-collections#1116)

Add missing `elements` option to type: list that did not specify

SUMMARY
Fixes ansible-collections#1114
ISSUE TYPE

Docs Pull Request

COMPONENT NAME

cloudfront_distribution
ecs_taskdefinition
elb_application_lb
rds_option_group

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Jill R <None>
(cherry picked from commit c1d47dd)
@jatorcasso jatorcasso force-pushed the patchback/backports/stable-2/sanity-fixes-milestone branch from 6b322c9 to 49c45fa Compare May 6, 2022 05:46
@jatorcasso jatorcasso marked this pull request as ready for review May 6, 2022 05:46
@ansibullbot ansibullbot added community_review and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels May 6, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 5m 05s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 52s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 54s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 11s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 11m 54s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 06s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 58s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 59s
✔️ ansible-test-splitter SUCCESS in 4m 08s
✔️ integration-community.aws-1 SUCCESS in 16m 42s
✔️ integration-community.aws-2 SUCCESS in 7m 37s
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label May 6, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 5m 18s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 47s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 16s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 49s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 01s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 13s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 48s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 16s
✔️ ansible-test-splitter SUCCESS in 2m 51s
✔️ integration-community.aws-1 SUCCESS in 15m 37s
✔️ integration-community.aws-2 SUCCESS in 8m 12s
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 4e86975 into ansible-collections:stable-2 May 6, 2022
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
Merge release changelogs into main branch

SUMMARY
Cherrypicks from:

Prepare 3.5.0 release (ansible-collections#1124)
Prepare release 4.3.0 (#1125)
Prepare 5.0.1 with minor bugfixes (ansible-collections#1123)
Prepare 5.0.2 release (ansible-collections#1143)

ISSUE TYPE

Docs Pull Request

COMPONENT NAME
Merge in the changelogs from 3.5.0, 4.3.0, 5.0.1 and 5.0.2 into the main changelog
ADDITIONAL INFORMATION

Reviewed-by: Gonéri Le Bouder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review connection connection plugin docs mergeit Merge the PR (SoftwareFactory) module module plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants