Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1093/c9784148 backport][stable-2] iam_policy - update examples, add RETURN, add required_if case #1096

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Apr 26, 2022

This is a backport of PR #1093 as merged into main (c978414).

SUMMARY
  • fix broken example
  • add RETURN documentation
  • require one of policy_document or policy_json when state is present
  • add extra integration tests for check mode idempotency cases
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

iam_policy

iam_policy - update examples, add RETURN, add required_if case

SUMMARY

fix broken example
add RETURN documentation
require one of policy_document or policy_json when state is present
add extra integration tests for check mode idempotency cases

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
iam_policy

Reviewed-by: Mark Chappell <None>
Reviewed-by: Markus Bergholz <[email protected]>
(cherry picked from commit c978414)
@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Apr 26, 2022
@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label May 5, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

ansible-galaxy-importer FAILURE in 4m 44s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 19s
ansible-test-sanity-docker-devel FAILURE in 10m 44s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 10m 07s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 07s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 59s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 47s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 17s
✔️ ansible-test-splitter SUCCESS in 3m 59s
✔️ integration-community.aws-1 SUCCESS in 5m 48s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@jatorcasso
Copy link
Contributor

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

ansible-galaxy-importer FAILURE in 4m 27s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 54s
ansible-test-sanity-docker-devel FAILURE in 11m 23s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 9m 35s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 14m 11s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 12m 34s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 25s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 8m 00s
✔️ ansible-test-splitter SUCCESS in 2m 54s
✔️ integration-community.aws-1 SUCCESS in 6m 27s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@jatorcasso
Copy link
Contributor

Depends-On: #1124

@markuman
Copy link
Member

markuman commented May 6, 2022

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 4m 21s (non-voting)
✔️ build-ansible-collection SUCCESS in 6m 49s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 27s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 28s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 25s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 23s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 45s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 31s
✔️ ansible-test-splitter SUCCESS in 3m 09s
✔️ integration-community.aws-1 SUCCESS in 7m 09s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 2277f5c into stable-2 May 6, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-2/c97841482bff44038ae357d625cc27a11c8efed0/pr-1093 branch May 6, 2022 13:09
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
Expand unit tests for module_utils.cloud

SUMMARY
Expand unit tests for module_utils.cloud
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/module_utils/cloud.py
ADDITIONAL INFORMATION
Expand unit test coverage for module_utils.cloud

Reviewed-by: Gonéri Le Bouder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants