-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community.aws.route53_info query:record_sets - type and max_items ignored on all 2.10 versions #529
Comments
Files identified in the description: If these files are inaccurate, please update the |
!component =plugins/modules/route53_info.py |
Files identified in the description:
If these files are inaccurate, please update the |
I don't think this has any relation to #523:
I checked the version of the module included in Ansible 2.9, it also ignored Looking at the commit history, the most likely candidate is ansible/ansible@6075536#diff-23a0c9250633162d50c3f06442b7a552a5ae0659a24dd01a328c0e165e473616. |
+ Previous method of getting route53 records (using route53 module with state=get), has an issue in Ansible 2.10.7 where the return values have changed due to boto3 migration (ansible-collections/community.aws#523). + In any case, state=get on the route53 module is not likely to remain supported indefinitely. + Using the route53_info module also has some issues with ignoring type and max_items (ansible-collections/community.aws#529), so these are worked around in this fix by post-filtering the output.
+ Previous method of getting route53 records (using route53 module with state=get), has an issue in Ansible 2.10.7 where the return values have changed due to boto3 migration (ansible-collections/community.aws#523). + In any case, state=get on the route53 module is not likely to remain supported indefinitely. + Using the route53_info module also has some issues with ignoring type and max_items (ansible-collections/community.aws#529), so these are worked around in this fix by post-filtering the output. + Do not call route53_info asynchronously, as it makes too many concurrent requests and blows the AWS Route53 API limit.
+ Previous method of getting route53 records (using route53 module with state=get), has an issue in Ansible 2.10.7 where the return values have changed due to boto3 migration (ansible-collections/community.aws#523). + In any case, state=get on the route53 module is not likely to remain supported indefinitely. + Using the route53_info module also has some issues with ignoring type and max_items (ansible-collections/community.aws#529), so these are worked around in this fix by post-filtering the output. + Do not call route53_info asynchronously, as it makes too many concurrent requests and blows the AWS Route53 API limit.
…sions. + Using route53 info in clean/tasks/dns.yml is too slow with large recordsets, (hopefully only until ansible-collections/community.aws#529 is fixed). + It is only supported between Ansible 2.9.6 and 2.10.6 and after Ansible 4; assertions added to pre-flight check.
…rsions. (#3) + Using `route53_zone`/ `route53_info`/ `route53` in clean/tasks/dns.yml is too slow with large recordsets, (hopefully only until ansible-collections/community.aws#529 is fixed). + Old mechanism (`route53(state=get)`) is only supported between Ansible 2.9.6 and 2.10.6 and after Ansible 4; assertions added to pre-flight check.
+ Previous method of getting route53 records (using route53 module with state=get), has an issue in Ansible 2.10.7 where the return values have changed due to boto3 migration (ansible-collections/community.aws#523). + In any case, state=get on the route53 module is not likely to remain supported indefinitely. + Using the route53_info module also has some issues with ignoring type and max_items (ansible-collections/community.aws#529), so these are worked around in this fix by post-filtering the output. + Do not call route53_info asynchronously, as it makes too many concurrent requests and blows the AWS Route53 API limit.
…delete (#92) * Use route53_info to get record sets for delete + Previous method of getting route53 records (using route53 module with state=get), has an issue in Ansible 2.10.7 where the return values have changed due to boto3 migration (ansible-collections/community.aws#523). + In any case, state=get on the route53 module is not likely to remain supported indefinitely. + Using the route53_info module also has some issues with ignoring type and max_items (ansible-collections/community.aws#529), so these are worked around in this fix by post-filtering the output. + Do not call route53_info asynchronously, as it makes too many concurrent requests and blows the AWS Route53 API limit. * Fix for private zone * Fix non-private DNS. Add testsuite support for scaling up/down * Break dependence upon 2.9.6 <= Ansible <= 2.10.6. Route53 deletion enhancement. * Remove '--format json' from 'ansible-galaxy collection list' assertion, as 'format option' is not present in ansible-galaxy 2.10.x
I can confirm that this issues also/still exists in Ansible |
Also in Ansible 2.10.12/community.aws 1.5.0. I also get a warning:
|
Fix route53_info max_items / type being ignored SUMMARY Currently if max_items is set on the route53_info module then it is ignored meaning all items are returned. type is also ignored due to an incorrect if statement It looks like it was a regression introduced here: ansible/ansible@6075536#diff-23a0c9250633162d50c3f06442b7a552a5ae0659a24dd01a328c0e165e473616 The tests have been updated to reflect a check on max_items and type Fixes: #529 ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_info ADDITIONAL INFORMATION The problem with max_items being ignored is resolved by adding PaginationConfig and adding MaxItems to that instead. The problem with type being ignored is resolved by fixing an if statement. Boto3 docs: https://boto3.amazonaws.com/v1/documentation/api/1.18.7/reference/services/route53.html#Route53.Paginator.ListResourceRecordSets Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
…o get current records + route53_info module doesn't honour the max_items or type fields (ansible-collections/community.aws#529), so if you have lots of records, it can take a very long time to return. This is likely fixed in ansible>=6.0.0)
…meter if no name and no filter provided (ansible-collections#529) ec2_instance When searching for instances fall back to tag(Name) parameter if no name and no filter provided SUMMARY Reported in ansible-collections#526 When the name parameter isn't set but the Name tag is set the Name tag is ignored when searching for existing instances. The documentation states: - By default, instances are filtered for counting by their "Name" tag, base AMI, state (running, by default), and subnet ID. As such I think we should consider this a bug. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION fixes: ansible-collections#526 Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
) Fix route53_info max_items / type being ignored SUMMARY Currently if max_items is set on the route53_info module then it is ignored meaning all items are returned. type is also ignored due to an incorrect if statement It looks like it was a regression introduced here: ansible/ansible@6075536#diff-23a0c9250633162d50c3f06442b7a552a5ae0659a24dd01a328c0e165e473616 The tests have been updated to reflect a check on max_items and type Fixes: ansible-collections#529 ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_info ADDITIONAL INFORMATION The problem with max_items being ignored is resolved by adding PaginationConfig and adding MaxItems to that instead. The problem with type being ignored is resolved by fixing an if statement. Boto3 docs: https://boto3.amazonaws.com/v1/documentation/api/1.18.7/reference/services/route53.html#Route53.Paginator.ListResourceRecordSets Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@e323f83
SUMMARY
on every 2.10.x ansible-base version, when using
community.aws.route53_info
module withquery:record_sets
:max_items
is ignored.type
is ignored.same issue also mentioned here community.aws.route53 state:get - return value differs between 2.10.7 and 2.10.6 #523
under 2.9.x versions everything works fine.
ISSUE TYPE
COMPONENT NAME
community.aws.route53_info
plugins/modules/route53_info.py
ANSIBLE VERSION
tested with every version under 2.10
but for this exmaple:
CONFIGURATION
OS / ENVIRONMENT
STEPS TO REPRODUCE
EXPECTED RESULTS
single A record due to max_items:1 with type: "A"
ACTUAL RESULTS
all records with every type under the host_zone.
cant paste the actual results due to privacy, but its easy to reproduce.
The text was updated successfully, but these errors were encountered: