ec2_instance When searching for instances fall back to tag(Name) para…

…meter if no name and no filter provided (ansible-collections#529)

ec2_instance When searching for instances fall back to tag(Name) parameter if no name and no filter provided

SUMMARY
Reported in ansible-collections#526
When the name parameter isn't set but the Name tag is set the Name tag is ignored when searching for existing instances.
The documentation states:
- By default, instances are filtered for counting by their "Name" tag, base AMI, state (running, by default), and
  subnet ID.

As such I think we should consider this a bug.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION
fixes: ansible-collections#526

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>

changelogs/fragments/526-ec2_instance_search_tags.yml

@@ -0,0 +1,2 @@
+bugfixes:
+- ec2_instance - ensure that ec2_instance falls back to the tag(Name) parameter when no filter and no name parameter is passed (https://github.com/ansible-collections/amazon.aws/issues/526).

plugins/modules/ec2_instance.py

@@ -1798,6 +1798,10 @@ def build_filters():
 
         if module.params.get('name'):
             filters['tag:Name'] = [module.params.get('name')]
+        elif module.params.get('tags'):
+            name_tag = module.params.get('tags').get('Name', None)
+            if name_tag:
+                filters['tag:Name'] = [name_tag]
 
         if module.params.get('image_id'):
             filters['image-id'] = [module.params.get('image_id')]

tests/integration/targets/ec2_instance/inventory

@@ -1,4 +1,5 @@
 [tests]
+instance_minimal
 checkmode_tests
 termination_protection
 ebs_optimized