Skip to content

Commit

Permalink
Use route53_info to get record sets for delete
Browse files Browse the repository at this point in the history 
+ Previous method of getting route53 records (using route53 module with state=get), has an issue in Ansible 2.10.7 where the return values have changed due to boto3 migration (ansible-collections/community.aws#523).
+ In any case, state=get on the route53 module is not likely to remain supported indefinitely.
+ Using the route53_info module also has some issues with ignoring type and max_items (ansible-collections/community.aws#529), so these are worked around in this fix by post-filtering the output.
  • Loading branch information
Dougal Seeley committed Apr 17, 2021
1 parent b62a3e1 commit f1a2a40
Show file tree
Hide file tree
Showing 2 changed files with 59 additions and 46 deletions.
2 changes: 1 addition & 1 deletion _dependencies/tasks/main.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

- name: Preflight check
block:
- assert: { that: "ansible_version.full is version_compare('2.10', '>=') and ansible_version.full is version_compare('2.10.6', '<=')", fail_msg: "2.10.6 >= Ansible >= 2.10 required." } #2.10.7 has issue with AWS DNS: https://github.com/ansible-collections/community.aws/issues/523
- assert: { that: "ansible_version.full is version_compare('2.10', '>=')", fail_msg: "Ansible > 2.10 required for Azure support." }
- assert: { that: "app_name is defined and app_name != ''", fail_msg: "Please define app_name" }
- assert: { that: "app_class is defined and app_class != ''", fail_msg: "Please define app_class" }
- assert: { that: "cluster_vars is defined", fail_msg: "Please define cluster_vars" }
Expand Down
103 changes: 58 additions & 45 deletions clean/tasks/dns.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,76 +35,89 @@

- name: clean/dns/route53 | Delete DNS entries
block:
# - name: clean/dns/route53 | Get Zone
# route53_zone:
# aws_access_key: "{{cluster_vars[buildenv].aws_access_key}}"
# aws_secret_key: "{{cluster_vars[buildenv].aws_secret_key}}"
# zone: "{{cluster_vars.dns_nameserver_zone}}"
# register: r__route53_zone
#
# - name: clean/dns/route53 | Get A records
# route53_info:
# query: record_sets
# hosted_zone_id: "{{ r__route53_zone.zone_id }}"
# start_record_name: "{{item.name}}.{{cluster_vars.dns_user_domain}}"
# register: r__route53_info
# with_items: "{{ hosts_to_clean }}"

- name: clean/dns/route53 | Get A records
route53:
- name: clean/dns/route53 | Get Zone
route53_zone:
aws_access_key: "{{cluster_vars[buildenv].aws_access_key}}"
aws_secret_key: "{{cluster_vars[buildenv].aws_secret_key}}"
state: "get"
zone: "{{cluster_vars.dns_nameserver_zone}}"
record: "{{item.name}}.{{cluster_vars.dns_user_domain}}"
register: r__route53_zone

# Note: route53_info currently does not honour the 'max_items' or 'type' fields, (and if 'start_record_name' is not found, it just returns all records), so we need to filter the responses to match 'hosts_to_clean' when doing the delete
- name: clean/dns/route53 | Get A records asynchronously
route53_info:
type: "A"
private_zone: "{{cluster_vars.route53_private_zone | default(true)}}"
register: r__route53_a
max_items: 1
query: record_sets
hosted_zone_id: "{{ r__route53_zone.zone_id }}"
start_record_name: "{{item.name}}.{{cluster_vars.dns_user_domain}}"
register: r__route53_info
with_items: "{{ hosts_to_clean }}"
async: 7200
poll: 0

- debug: msg={{r__route53_a}}
- name: clean/dns/route53 | Wait for A records to be fetched
async_status: { jid: "{{ item.ansible_job_id }}" }
register: r__async_status__route53_info
until: r__async_status__route53_info.finished
delay: 1
retries: 300
with_items: "{{r__route53_info.results}}"

- name: clean/dns/route53 | Delete A records
route53:
aws_access_key: "{{cluster_vars[buildenv].aws_access_key}}"
aws_secret_key: "{{cluster_vars[buildenv].aws_secret_key}}"
state: "absent"
zone: "{{ item.set.zone }}"
record: "{{ item.set.record }}"
type: "{{ item.set.type }}"
ttl: "{{ item.set.ttl }}"
value: ["{{ item.set.value }}"]
zone: "{{ cluster_vars.dns_nameserver_zone }}"
record: "{{ item.Name }}"
type: "{{ item.Type }}"
ttl: "{{ item.TTL }}"
value: "{{ item.ResourceRecords | json_query(\"[].Value\") }}"
private_zone: "{{cluster_vars.route53_private_zone | default(true)}}"
with_items: "{{ r__route53_a.results }}"
when: item.set.value is defined
with_items: "{{ records_to_clean }}"
vars:
_hostnames_to_clean: "{{ hosts_to_clean | json_query(\"[].name\") | map('regex_replace', '^(.*)$', '\\1.' + cluster_vars.dns_user_domain + '.') }}"
records_to_clean: "{{ r__async_status__route53_info.results | json_query(\"[].ResourceRecordSets[?Type=='A' && contains(\"+ _hostnames_to_clean | string +\", Name)][]\") | unique }}"

- name: clean/dns/route53 | Get CNAME records
route53:
aws_access_key: "{{cluster_vars[buildenv].aws_access_key}}"
aws_secret_key: "{{cluster_vars[buildenv].aws_secret_key}}"
state: "get"
zone: "{{cluster_vars.dns_nameserver_zone}}"
record: "{{item.name | regex_replace('-(?!.*-).*')}}.{{cluster_vars.dns_user_domain}}"
# Note: route53_info currently does not honour the 'max_items' or 'type' fields, (and if 'start_record_name' is not found, it just returns all records), so we need to filter the responses to match 'hosts_to_clean' when doing the delete
- name: clean/dns/route53 | Get CNAME records asynchronously
route53_info:
type: "CNAME"
private_zone: "{{cluster_vars.route53_private_zone | default(true)}}"
register: r__route53_cname
max_items: 1
query: record_sets
hosted_zone_id: "{{ r__route53_zone.zone_id }}"
start_record_name: "{{item.name | regex_replace('-(?!.*-).*')}}.{{cluster_vars.dns_user_domain}}"
register: r__route53_info
with_items: "{{ hosts_to_clean }}"
async: 7200
poll: 0

- name: clean/dns/route53 | Wait for CNAME records to be fetched
async_status: { jid: "{{ item.ansible_job_id }}" }
register: r__async_status__route53_info
until: r__async_status__route53_info.finished
delay: 1
retries: 300
with_items: "{{r__route53_info.results}}"

- name: clean/dns/route53 | Delete CNAME records
route53:
aws_access_key: "{{cluster_vars[buildenv].aws_access_key}}"
aws_secret_key: "{{cluster_vars[buildenv].aws_secret_key}}"
state: "absent"
zone: "{{ item.1.set.zone }}"
record: "{{ item.1.set.record }}"
type: "{{ item.1.set.type }}"
ttl: "{{ item.1.set.ttl }}"
value: ["{{ item.1.set.value }}"]
zone: "{{ cluster_vars.dns_nameserver_zone }}"
record: "{{ item.1.Name }}"
type: "{{ item.1.Type }}"
ttl: "{{ item.1.TTL }}"
value: "{{ item.1.ResourceRecords | json_query(\"[].Value\") }}"
private_zone: "{{cluster_vars.route53_private_zone | default(true)}}"
vars:
_cnames_to_clean: "{{ hosts_to_clean | json_query(\"[].name\") | map('regex_replace', '^(.*)-(?!.*-).*$', '\\1.' + cluster_vars.dns_user_domain + '.') }}" #Remove the last '-.*' (cluster_suffix)
records_to_clean: "{{ r__async_status__route53_info.results | json_query(\"[].ResourceRecordSets[?Type=='CNAME' && contains(\"+ _cnames_to_clean | string +\", Name)][]\") | unique }}"
with_nested:
- "{{ hosts_to_clean }}"
- "{{ r__route53_cname.results }}"
when: (item.1.set.value is defined) and ((item.0.name | regex_replace('-(?!.*-).*')) == (item.1.set.record | regex_replace('^(.*?)\\..*$', '\\1'))) and (item.0.name == item.1.set.value | regex_replace('^(.*?)\\..*$', '\\1'))
- "{{ records_to_clean }}"
when: ((item.0.name | regex_replace('-(?!.*-).*')) == (item.1.Name | regex_replace('^(.*?)\\..*$', '\\1'))) and ((item.0.name == item.1.ResourceRecords[0].Value | regex_replace('^(.*?)\\..*$', '\\1')))
when: cluster_vars.dns_server == "route53"

- name: clean/dns/clouddns | Delete DNS entries
Expand Down

0 comments on commit f1a2a40

Please sign in to comment.