[PR #902/5693b52e backport][stable-4] Remove old lookup unit tests #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
Remove old lookup unit tests SUMMARY Remove the unit tests for the aws_ssm and aws_secret lookup plugins. These unit tests weren't testing individual functions, they were testing the 'whole' module, and as such are brittle and break if the underlying implementation is updated (such as a refactor). Since we now have supported integration tests, remove the unit tests. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/lookup/aws_ssm.py plugins/lookup/aws_secret.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> (cherry picked from commit 5693b52)
tremble
approved these changes
Jun 28, 2022
ansibullbot
added
community_review
feature
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 30s |
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-4/5693b52e5a8ce8a0893ce6e6f83f0d3275b69490/pr-902
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #902 as merged into main (5693b52).
SUMMARY
Remove the unit tests for the aws_ssm and aws_secret lookup plugins.
These unit tests weren't testing individual functions, they were testing the 'whole' module, and as such are brittle and break if the underlying implementation is updated (such as a refactor). Since we now have supported integration tests, remove the unit tests.
ISSUE TYPE
COMPONENT NAME
plugins/lookup/aws_ssm.py
plugins/lookup/aws_secret.py
ADDITIONAL INFORMATION