Remove old lookup unit tests #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
tremble
force-pushed
the
units/remove/lookup
branch
from
6d7b7da to
94541c8
Compare
tremble
added
backport-4
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 05s |
alinabuzachis
approved these changes
Jun 28, 2022
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 28s |
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #905 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 28, 2022
Remove old lookup unit tests SUMMARY Remove the unit tests for the aws_ssm and aws_secret lookup plugins. These unit tests weren't testing individual functions, they were testing the 'whole' module, and as such are brittle and break if the underlying implementation is updated (such as a refactor). Since we now have supported integration tests, remove the unit tests. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/lookup/aws_ssm.py plugins/lookup/aws_secret.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> (cherry picked from commit 5693b52)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jun 28, 2022
[PR #902/5693b52e backport][stable-4] Remove old lookup unit tests This is a backport of PR #902 as merged into main (5693b52). SUMMARY Remove the unit tests for the aws_ssm and aws_secret lookup plugins. These unit tests weren't testing individual functions, they were testing the 'whole' module, and as such are brittle and break if the underlying implementation is updated (such as a refactor). Since we now have supported integration tests, remove the unit tests. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/lookup/aws_ssm.py plugins/lookup/aws_secret.py ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
aws_acm: fix yamllint errors in docs section SUMMARY Closes: ansible-collections#902 ISSUE TYPE Docs Pull Request COMPONENT NAME aws_acm ADDITIONAL INFORMATION 1:1 warning missing document start "---" (document-start) 2:81 error line too long (88 > 80 characters) (line-length) 5:81 error line too long (89 > 80 characters) (line-length) 9:81 error line too long (86 > 80 characters) (line-length) 11:81 error line too long (100 > 80 characters) (line-length) 32:81 error line too long (87 > 80 characters) (line-length) 36:81 error line too long (98 > 80 characters) (line-length) 41:81 error line too long (98 > 80 characters) (line-length) 43:81 error line too long (105 > 80 characters) (line-length) 49:81 error line too long (84 > 80 characters) (line-length) 56:81 error line too long (102 > 80 characters) (line-length) 61:81 error line too long (87 > 80 characters) (line-length) 69:81 error line too long (91 > 80 characters) (line-length) 79:81 error line too long (92 > 80 characters) (line-length) 88:81 error line too long (85 > 80 characters) (line-length) 105:81 error line too long (83 > 80 characters) (line-length) 123:1 error wrong indentation: expected 2 but found 0 (indentation) 124:17 error no new line character at the end of file (new-line-at-end-of-file) Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
aws_acm: fix yamllint errors in docs section SUMMARY Closes: ansible-collections#902 ISSUE TYPE Docs Pull Request COMPONENT NAME aws_acm ADDITIONAL INFORMATION 1:1 warning missing document start "---" (document-start) 2:81 error line too long (88 > 80 characters) (line-length) 5:81 error line too long (89 > 80 characters) (line-length) 9:81 error line too long (86 > 80 characters) (line-length) 11:81 error line too long (100 > 80 characters) (line-length) 32:81 error line too long (87 > 80 characters) (line-length) 36:81 error line too long (98 > 80 characters) (line-length) 41:81 error line too long (98 > 80 characters) (line-length) 43:81 error line too long (105 > 80 characters) (line-length) 49:81 error line too long (84 > 80 characters) (line-length) 56:81 error line too long (102 > 80 characters) (line-length) 61:81 error line too long (87 > 80 characters) (line-length) 69:81 error line too long (91 > 80 characters) (line-length) 79:81 error line too long (92 > 80 characters) (line-length) 88:81 error line too long (85 > 80 characters) (line-length) 105:81 error line too long (83 > 80 characters) (line-length) 123:1 error wrong indentation: expected 2 but found 0 (indentation) 124:17 error no new line character at the end of file (new-line-at-end-of-file) Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
aws_acm: fix yamllint errors in docs section SUMMARY Closes: ansible-collections#902 ISSUE TYPE Docs Pull Request COMPONENT NAME aws_acm ADDITIONAL INFORMATION 1:1 warning missing document start "---" (document-start) 2:81 error line too long (88 > 80 characters) (line-length) 5:81 error line too long (89 > 80 characters) (line-length) 9:81 error line too long (86 > 80 characters) (line-length) 11:81 error line too long (100 > 80 characters) (line-length) 32:81 error line too long (87 > 80 characters) (line-length) 36:81 error line too long (98 > 80 characters) (line-length) 41:81 error line too long (98 > 80 characters) (line-length) 43:81 error line too long (105 > 80 characters) (line-length) 49:81 error line too long (84 > 80 characters) (line-length) 56:81 error line too long (102 > 80 characters) (line-length) 61:81 error line too long (87 > 80 characters) (line-length) 69:81 error line too long (91 > 80 characters) (line-length) 79:81 error line too long (92 > 80 characters) (line-length) 88:81 error line too long (85 > 80 characters) (line-length) 105:81 error line too long (83 > 80 characters) (line-length) 123:1 error wrong indentation: expected 2 but found 0 (indentation) 124:17 error no new line character at the end of file (new-line-at-end-of-file) Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Remove the unit tests for the aws_ssm and aws_secret lookup plugins.
These unit tests weren't testing individual functions, they were testing the 'whole' module, and as such are brittle and break if the underlying implementation is updated (such as a refactor). Since we now have supported integration tests, remove the unit tests.
ISSUE TYPE
COMPONENT NAME
plugins/lookup/aws_ssm.py
plugins/lookup/aws_secret.py
ADDITIONAL INFORMATION