Skip to content

Commit

Permalink
Remove old lookup unit tests (#902) (#905)
Browse files Browse the repository at this point in the history
[PR #902/5693b52e backport][stable-4] Remove old lookup unit tests

This is a backport of PR #902 as merged into main (5693b52).
SUMMARY
Remove the unit tests for the aws_ssm and aws_secret lookup plugins.
These unit tests weren't testing individual functions, they were testing the 'whole' module, and as such are brittle and break if the underlying implementation is updated (such as a refactor).  Since we now have supported integration tests, remove the unit tests.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/lookup/aws_ssm.py
plugins/lookup/aws_secret.py
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
  • Loading branch information
patchback[bot] authored Jun 28, 2022
1 parent c77f5e6 commit 9c117c6
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 734 deletions.
Empty file.
104 changes: 0 additions & 104 deletions tests/unit/plugins/lookup/fixtures/avi.json

This file was deleted.

288 changes: 0 additions & 288 deletions tests/unit/plugins/lookup/test_aws_secret.py

This file was deleted.

Loading

0 comments on commit 9c117c6

Please sign in to comment.