ec2_instance - Fix NoneType error on no input tags #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
tremble
requested changes
Jun 1, 2022
changelogs/fragments/856-ec2_instance-fix-nonetype-on-no-tags.yml
Outdated
Show resolved
Hide resolved
|
@tremble updated tagging logic with some integration tests to validate |
ansibullbot
added
integration
|
recheck |
|
recheck |
tremble
approved these changes
Jun 2, 2022
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jun 9, 2022
*_info - improve RETURN block of docs Depends-On: #856 SUMMARY Fixes #843 Can things like checking for a period after description be added to our sanity checks? ISSUE TYPE Docs Pull Request COMPONENT NAME aws_ax_info aws_caller_info aws_s3 cloudformation_info ec2_eni_info ec2_group ec2_group_info ec2_instance_info ec2_key ec2_metadata_facts ec2_snapshot_info ec2_spot_instance ec2_spot_instance_info ec2_tag ec2_tag_info ec2_vpc_dhcp_option_info ec2_vpc_endpoint_info ec2_vpc_endpoint_service_info ec2_vpc_igw_info ec2_vpc_nat_gateway ec2_vpc_nat_gateway_info ec2_vpc_net_info ec2_vpc_route_table_info elb_classic_lb Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None>
jatorcasso
added a commit
to jatorcasso/amazon.aws
that referenced
this pull request
Jun 27, 2022
*_info - improve RETURN block of docs Depends-On: ansible-collections#856 SUMMARY Fixes ansible-collections#843 Can things like checking for a period after description be added to our sanity checks? ISSUE TYPE Docs Pull Request COMPONENT NAME aws_ax_info aws_caller_info aws_s3 cloudformation_info ec2_eni_info ec2_group ec2_group_info ec2_instance_info ec2_key ec2_metadata_facts ec2_snapshot_info ec2_spot_instance ec2_spot_instance_info ec2_tag ec2_tag_info ec2_vpc_dhcp_option_info ec2_vpc_endpoint_info ec2_vpc_endpoint_service_info ec2_vpc_igw_info ec2_vpc_nat_gateway ec2_vpc_nat_gateway_info ec2_vpc_net_info ec2_vpc_route_table_info elb_classic_lb Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Reverts bug introduced in #849 which throws a NoneType exception when tags are not input
ISSUE TYPE
COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION
The error gets thrown when trying to wrap dict(None). See https://ansible.softwarefactory-project.io/zuul/build/5e37b5947f7045c6bf01e88f8ae5271f