Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*_info modules missing/inaccurate RETURN data #843

Closed
1 task done
jatorcasso opened this issue May 26, 2022 · 2 comments · Fixed by #855
Closed
1 task done

*_info modules missing/inaccurate RETURN data #843

jatorcasso opened this issue May 26, 2022 · 2 comments · Fixed by #855
Assignees
@jatorcasso
Labels
docs has_pr jira waiting_on_contributor Needs help. Feel free to engage to get things unblocked

Comments

@jatorcasso
Copy link
Contributor

Summary

There are quite a few missing/inaccurate/not detailed enough RETURN values in the info modules. These should be up to date.

Issue Type

Documentation Report

Component Name

*_info

Ansible Version

$ ansible --version

Collection Versions

$ ansible-galaxy collection list

Configuration

$ ansible-config dump --only-changed

OS / Environment

No response

Additional Information

No response

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@jatorcasso jatorcasso self-assigned this May 26, 2022
@ansibullbot
Copy link

Files identified in the description:
None

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@jillr jillr added waiting_on_contributor Needs help. Feel free to engage to get things unblocked and removed needs_triage labels May 31, 2022
@goneri goneri removed the waiting_on_contributor Needs help. Feel free to engage to get things unblocked label May 31, 2022
@goneri
Copy link
Member

goneri commented May 31, 2022

Hi @jatorcasso,

For the record, with vmware.vmware_rest, I use some kind of a script to refresh these fields. Ping me if you're interested.

@ansibullbot ansibullbot added the waiting_on_contributor Needs help. Feel free to engage to get things unblocked label May 31, 2022
@jatorcasso jatorcasso mentioned this issue Jun 1, 2022
Merged
@jatorcasso jatorcasso added the jira label Jun 2, 2022
softwarefactory-project-zuul bot pushed a commit that referenced this issue Jun 9, 2022
@jatorcasso
*_info - improve RETURN block of docs (#855)
caaf7e8 
*_info - improve RETURN block of docs

Depends-On: #856
SUMMARY
Fixes #843
Can things like checking for a period after description be added to our sanity checks?
ISSUE TYPE

Docs Pull Request

COMPONENT NAME

aws_ax_info
aws_caller_info
aws_s3
cloudformation_info
ec2_eni_info
ec2_group
ec2_group_info
ec2_instance_info
ec2_key
ec2_metadata_facts
ec2_snapshot_info
ec2_spot_instance
ec2_spot_instance_info
ec2_tag
ec2_tag_info
ec2_vpc_dhcp_option_info
ec2_vpc_endpoint_info
ec2_vpc_endpoint_service_info
ec2_vpc_igw_info
ec2_vpc_nat_gateway
ec2_vpc_nat_gateway_info
ec2_vpc_net_info
ec2_vpc_route_table_info
elb_classic_lb

Reviewed-by: Jill R <None>
Reviewed-by: Mark Chappell <None>
jatorcasso added a commit to jatorcasso/amazon.aws that referenced this issue Jun 27, 2022
@jatorcasso
*_info - improve RETURN block of docs (ansible-collections#855)
14f571e 
*_info - improve RETURN block of docs

Depends-On: ansible-collections#856
SUMMARY
Fixes ansible-collections#843
Can things like checking for a period after description be added to our sanity checks?
ISSUE TYPE

Docs Pull Request

COMPONENT NAME

aws_ax_info
aws_caller_info
aws_s3
cloudformation_info
ec2_eni_info
ec2_group
ec2_group_info
ec2_instance_info
ec2_key
ec2_metadata_facts
ec2_snapshot_info
ec2_spot_instance
ec2_spot_instance_info
ec2_tag
ec2_tag_info
ec2_vpc_dhcp_option_info
ec2_vpc_endpoint_info
ec2_vpc_endpoint_service_info
ec2_vpc_igw_info
ec2_vpc_nat_gateway
ec2_vpc_nat_gateway_info
ec2_vpc_net_info
ec2_vpc_route_table_info
elb_classic_lb

Reviewed-by: Jill R <None>
Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
@ykrysko
Add ability to manage resource policy for AWS Secrets Manager secrets (…
1198ce1 
…ansible-collections#843)

Add ability to manage resource policy for AWS Secrets Manager secrets

SUMMARY

AWS Secrets Manager secrets support attaching resource policy. The benefit is huge when necessary to access secrets from other AWS accounts. This pull request adds ability to manage (add new/remove or modify existing) secrets resource policy.

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

module: aws_secret
ADDITIONAL INFORMATION

Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Yuri Krysko <[email protected]>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
@ykrysko @abikouo
Add ability to manage resource policy for AWS Secrets Manager secrets (…
827238f 
…ansible-collections#843)

Add ability to manage resource policy for AWS Secrets Manager secrets

SUMMARY

AWS Secrets Manager secrets support attaching resource policy. The benefit is huge when necessary to access secrets from other AWS accounts. This pull request adds ability to manage (add new/remove or modify existing) secrets resource policy.

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

module: aws_secret
ADDITIONAL INFORMATION

Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Yuri Krysko <[email protected]>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Oct 24, 2023
@ykrysko
Add ability to manage resource policy for AWS Secrets Manager secrets (…
9110162 
…ansible-collections#843)

Add ability to manage resource policy for AWS Secrets Manager secrets

SUMMARY

AWS Secrets Manager secrets support attaching resource policy. The benefit is huge when necessary to access secrets from other AWS accounts. This pull request adds ability to manage (add new/remove or modify existing) secrets resource policy.

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

module: aws_secret
ADDITIONAL INFORMATION

Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Yuri Krysko <[email protected]>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jatorcasso jatorcasso

Labels
docs has_pr jira waiting_on_contributor Needs help. Feel free to engage to get things unblocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*_info - improve RETURN block of docs jatorcasso/amazon.aws
4 participants
@goneri @jillr @ansibullbot @jatorcasso