-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*_info - improve RETURN block of docs #855
*_info - improve RETURN block of docs #855
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
recheck |
recheck |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the typo LGTM - this should have a second review though because it's quite a lot of text to review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From experience, you may need to split out the changes to a couple of the slower tests to avoid timeouts. We used to manually balance the groups of tests, and while the new automatic balancing is much better than it used to be slow tests can still cause problems.
Co-authored-by: Jill R <[email protected]>
201ebec
to
af4c47d
Compare
recheck |
*_info - improve RETURN block of docs Depends-On: ansible-collections#856 SUMMARY Fixes ansible-collections#843 Can things like checking for a period after description be added to our sanity checks? ISSUE TYPE Docs Pull Request COMPONENT NAME aws_ax_info aws_caller_info aws_s3 cloudformation_info ec2_eni_info ec2_group ec2_group_info ec2_instance_info ec2_key ec2_metadata_facts ec2_snapshot_info ec2_spot_instance ec2_spot_instance_info ec2_tag ec2_tag_info ec2_vpc_dhcp_option_info ec2_vpc_endpoint_info ec2_vpc_endpoint_service_info ec2_vpc_igw_info ec2_vpc_nat_gateway ec2_vpc_nat_gateway_info ec2_vpc_net_info ec2_vpc_route_table_info elb_classic_lb Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None>
Depends-On: #856
SUMMARY
Fixes #843
Can things like checking for a period after
description
be added to our sanity checks?ISSUE TYPE
COMPONENT NAME