ec2_vpc_igw: fix 'NoneType' object is not subscriptable (#691) #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ections#691) ec2_vpc_igw: fix 'NoneType' object is not subscriptable Depends-On: ansible/ansible-zuul-jobs#1368 SUMMARY Add "InternetGatewayAttached" waiter Fixes ansible-collections#647 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None> Reviewed-by: Abhijeet Kasurde <None> (cherry picked from commit 8cc9397)
ansibullbot
added
bug
softwarefactory-project-zuul
bot
merged commit 787bb74
into
ansible-collections:stable-2
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ections#762) add `KmsMasterKeyId` as attribute option for boto3 call SUMMARY When creating a SQS queue, passing a value for KmsMasterKeyId does not enable SSE. This PR fixes how attributes, like KmsMasterKeyId, are passed into the boto3 invocation. Fixes: ansible-collections#698 ISSUE TYPE Bugfix Pull Request COMPONENT NAME sqs_queue.py Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None> Reviewed-by: James McClune <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ections#762) add `KmsMasterKeyId` as attribute option for boto3 call SUMMARY When creating a SQS queue, passing a value for KmsMasterKeyId does not enable SSE. This PR fixes how attributes, like KmsMasterKeyId, are passed into the boto3 invocation. Fixes: ansible-collections#698 ISSUE TYPE Bugfix Pull Request COMPONENT NAME sqs_queue.py Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None> Reviewed-by: James McClune <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…ections#762) add `KmsMasterKeyId` as attribute option for boto3 call SUMMARY When creating a SQS queue, passing a value for KmsMasterKeyId does not enable SSE. This PR fixes how attributes, like KmsMasterKeyId, are passed into the boto3 invocation. Fixes: ansible-collections#698 ISSUE TYPE Bugfix Pull Request COMPONENT NAME sqs_queue.py Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None> Reviewed-by: James McClune <None> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport to stable-2: ec2_vpc_igw: fix 'NoneType' object is not subscriptable
SUMMARY
Add "InternetGatewayAttached" waiter
Fixes #647
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
ec2_vpc_igw
Reviewed-by: Alina Buzachis
Reviewed-by: Joseph Torcasso
Reviewed-by: Jill R
Reviewed-by: Abhijeet Kasurde
(cherry picked from commit 8cc9397)
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION