Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default behavior of aws_s3 overwrite #762

Closed
1 task done
jlosito opened this issue Mar 30, 2022 · 3 comments · Fixed by #811
Closed
1 task done

Default behavior of aws_s3 overwrite #762

jlosito opened this issue Mar 30, 2022 · 3 comments · Fixed by #811
Assignees
@alinabuzachis
Labels
feature This issue/PR relates to a feature request module module plugins plugin (any type)

Comments

@jlosito
Copy link

jlosito commented Mar 30, 2022

Summary

I believe the default behavior of the aws_s3 module should be overwrite: different instead of always in order for the module to be idempotent by default. Every time the module runs with its current default behavior, ansible shows that something has changed. Usually a module will report no changes if ran multiple times by default.

Issue Type

Feature Idea

Component Name

aws_s3

Additional Information



Code of Conduct


    

  •  I agree to follow the Ansible Code of Conduct
    • 


      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
      



  

  @ansibullbot





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          
Files identified in the description:



If these files are inaccurate, please update the component name section of the description or use the !component bot command.


click here for bot help


      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @ansibullbot





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          
cc @jillr @linabuzachis @lwade @s-hertel @tremble

click here for bot help


      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @ansibullbot
ansibullbot




            added
      

  feature

  This issue/PR relates to a feature request

      

  module

  module

      

  needs_triage


      

  plugins

  plugin (any type)

  labels


      Mar 30, 2022

    

  



    







      

  
      



  

  @goneri





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

      

      
            goneri
  

      

      

      commented


        Apr 5, 2022


      
    


  





      


        


  
    

      
          
It's a good idea but it's also a breaking change. We should wait for a 3.0 release to introduce a change like this.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @alinabuzachis
alinabuzachis




              self-assigned this


      May 12, 2022

    

  



  

  

    
  


  

      

    @alinabuzachis
alinabuzachis



    mentioned this issue
    
      May 12, 2022
    





  


  

      
   Merged

  







  




    

    


  


  
    
  
  

    
  softwarefactory-project-zuul bot

      pushed a commit
      that referenced
      this issue

    
      Jun 8, 2022
    
    

      


  

    

      


  

      
        @alinabuzachis
  





      

        
          aws_s3 - ensure overwrite: different (#811)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          65f6fa4
        
      

    

  

    

      
aws_s3 - ensure overwrite: different

SUMMARY

aws_s3 - ensure overwrite: different instead of always in order for the module to be idempotent by default.
Fixes: #762

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

aws_s3

Reviewed-by: Jill R <None>
Reviewed-by: Mark Chappell <None>

    




    

  




  


  
    
  
  

    
  jatorcasso 

      pushed a commit
        to jatorcasso/amazon.aws
      that referenced
      this issue

    
      Jun 27, 2022
    
    

      


  

    

      


  

      
        @alinabuzachis
      
        @jatorcasso
  





      

        
          aws_s3 - ensure overwrite: different (ansible-collections#811)
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          512f936
        
      

    

  

    

      
aws_s3 - ensure overwrite: different

SUMMARY

aws_s3 - ensure overwrite: different instead of always in order for the module to be idempotent by default.
Fixes: ansible-collections#762

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

aws_s3

Reviewed-by: Jill R <None>
Reviewed-by: Mark Chappell <None>

    




    

  




  


  
    
  
  

    
  abikouo 

      pushed a commit
        to abikouo/amazon.aws
      that referenced
      this issue

    
      Sep 18, 2023
    
    

      


  

    

      


  

      
        @falcon78921
  





      

        
          add KmsMasterKeyId as attribute option for boto3 call (ansible-coll…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          b296616
        
      

    

  

    

      
…ections#762)

add `KmsMasterKeyId` as attribute option for boto3 call

SUMMARY

When creating a SQS queue, passing a value for KmsMasterKeyId does not enable SSE. This PR fixes how attributes, like KmsMasterKeyId, are passed into the boto3 invocation.
Fixes: ansible-collections#698
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

sqs_queue.py

Reviewed-by: Jill R <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: James McClune <None>
Reviewed-by: None <None>

    




    

  




  


  
    
  
  

    
  abikouo 

      pushed a commit
        to abikouo/amazon.aws
      that referenced
      this issue

    
      Sep 18, 2023
    
    

      


  

    

      


  

      
        @falcon78921
      
        @abikouo
  





      

        
          add KmsMasterKeyId as attribute option for boto3 call (ansible-coll…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          2a4aea7
        
      

    

  

    

      
…ections#762)

add `KmsMasterKeyId` as attribute option for boto3 call

SUMMARY

When creating a SQS queue, passing a value for KmsMasterKeyId does not enable SSE. This PR fixes how attributes, like KmsMasterKeyId, are passed into the boto3 invocation.
Fixes: ansible-collections#698
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

sqs_queue.py

Reviewed-by: Jill R <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: James McClune <None>
Reviewed-by: None <None>

    




    

  




  


  
    
  
  

    
  abikouo 

      pushed a commit
        to abikouo/amazon.aws
      that referenced
      this issue

    
      Oct 24, 2023
    
    

      


  

    

      


  

      
        @falcon78921
  





      

        
          add KmsMasterKeyId as attribute option for boto3 call (ansible-coll…
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          1a3ec82
        
      

    

  

    

      
…ections#762)

add `KmsMasterKeyId` as attribute option for boto3 call

SUMMARY

When creating a SQS queue, passing a value for KmsMasterKeyId does not enable SSE. This PR fixes how attributes, like KmsMasterKeyId, are passed into the boto3 invocation.
Fixes: ansible-collections#698
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

sqs_queue.py

Reviewed-by: Jill R <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: James McClune <None>
Reviewed-by: None <None>

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @alinabuzachis
  
    alinabuzachis
    

      








      


  


  

    Labels
  



    

      

    feature

  This issue/PR relates to a feature request
  

    module

  module
  

    plugins

  plugin (any type)








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




          
  
Successfully merging a pull request may close this issue.





    


  
          
      aws_s3 - ensure overwrite: different

    
      alinabuzachis/amazon.aws
    





    
  




      

    

  
      

  

    

      4 participants
    

    

        
          @goneri 
        
          @jlosito 
        
          @alinabuzachis 
        
          @ansibullbot