Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_s3 - ensure overwrite: different #811

Conversation

alinabuzachis
Copy link
Collaborator

@alinabuzachis alinabuzachis commented May 12, 2022

SUMMARY

aws_s3 - ensure overwrite: different instead of always in order for the module to be idempotent by default.

Fixes: #762

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

aws_s3

@github-actions
Copy link

github-actions bot commented May 12, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

cc @jillr @linabuzachis @lwade @s-hertel @tremble
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels May 12, 2022
@softwarefactory-project-zuul

This comment was marked as resolved.

Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as we don't merge until 4.0.0

@goneri
Copy link
Member

goneri commented May 17, 2022

recheck

@softwarefactory-project-zuul

This comment was marked as resolved.

@alinabuzachis
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul

This comment was marked as resolved.

@softwarefactory-project-zuul

This comment was marked as resolved.

@softwarefactory-project-zuul

This comment was marked as resolved.

@softwarefactory-project-zuul

This comment was marked as resolved.

@alinabuzachis
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul

This comment was marked as resolved.

@alinabuzachis
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul

This comment was marked as resolved.

@alinabuzachis
Copy link
Collaborator Author

cc @goneri

@ansibullbot

This comment was marked as resolved.

@ansibullbot ansibullbot added merge_commit This PR contains at least one merge commit. Please resolve! and removed community_review labels Jun 1, 2022
@ansibullbot ansibullbot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jun 1, 2022
@softwarefactory-project-zuul

This comment was marked as resolved.

@alinabuzachis
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul

This comment was marked as resolved.

Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the tests, I suspect that the owner information is only changing if the resource would otherwise be updated. This is probably a bug, but it's highlighted by the change in default behaviour.

plugins/modules/aws_s3.py Outdated Show resolved Hide resolved
@tremble tremble added the do_not_backport This PR should not be backported to stable- branches unless absolutely necessary label Jun 7, 2022
…he module to be idempotent by default

Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
@tremble tremble force-pushed the aws_s3_different branch from e488c7d to 3ab8e49 Compare June 8, 2022 10:05
@ansibullbot ansibullbot added community_review and removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jun 8, 2022
@softwarefactory-project-zuul

This comment was marked as resolved.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 21s
✔️ build-ansible-collection SUCCESS in 4m 41s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 38s
✔️ ansible-test-sanity-aws-ansible-2.9-python38 SUCCESS in 12m 12s
✔️ ansible-test-sanity-aws-ansible-2.11-python38 SUCCESS in 9m 30s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 15s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 51s
✔️ ansible-test-splitter SUCCESS in 2m 27s
✔️ integration-amazon.aws-1 SUCCESS in 8m 56s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

Signed-off-by: Alina Buzachis <[email protected]>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 35s
✔️ build-ansible-collection SUCCESS in 5m 02s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 55s
✔️ ansible-test-sanity-aws-ansible-2.9-python38 SUCCESS in 14m 22s
✔️ ansible-test-sanity-aws-ansible-2.11-python38 SUCCESS in 11m 08s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 55s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 02s
✔️ ansible-test-splitter SUCCESS in 2m 29s
✔️ integration-amazon.aws-1 SUCCESS in 9m 42s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 8m 56s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 8, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 08s
✔️ build-ansible-collection SUCCESS in 5m 12s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 30s
✔️ ansible-test-sanity-aws-ansible-2.9-python38 SUCCESS in 10m 22s
✔️ ansible-test-sanity-aws-ansible-2.11-python38 SUCCESS in 10m 10s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 32s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 21s
✔️ ansible-test-splitter SUCCESS in 2m 55s
✔️ integration-amazon.aws-1 SUCCESS in 9m 53s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 65f6fa4 into ansible-collections:main Jun 8, 2022
jatorcasso pushed a commit to jatorcasso/amazon.aws that referenced this pull request Jun 27, 2022
aws_s3 - ensure overwrite: different

SUMMARY

aws_s3 - ensure overwrite: different instead of always in order for the module to be idempotent by default.
Fixes: ansible-collections#762

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

aws_s3

Reviewed-by: Jill R <None>
Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
add patchback configs

SUMMARY
Add the configs so that we can use the patchback bot for semi-automated backports.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
.github
ADDITIONAL INFORMATION

Reviewed-by: Felix Fontein <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review do_not_backport This PR should not be backported to stable- branches unless absolutely necessary feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default behavior of aws_s3 overwrite
5 participants