-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_s3 - ensure overwrite: different #811
aws_s3 - ensure overwrite: different #811
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
3314eff
to
000ab6e
Compare
cc @jillr @linabuzachis @lwade @s-hertel @tremble |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as we don't merge until 4.0.0
recheck |
This comment was marked as resolved.
This comment was marked as resolved.
recheck |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
cb74837
to
80879df
Compare
This comment was marked as resolved.
This comment was marked as resolved.
80879df
to
73bd8ab
Compare
This comment was marked as resolved.
This comment was marked as resolved.
recheck |
This comment was marked as resolved.
This comment was marked as resolved.
recheck |
This comment was marked as resolved.
This comment was marked as resolved.
cc @goneri |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
recheck |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the tests, I suspect that the owner information is only changing if the resource would otherwise be updated. This is probably a bug, but it's highlighted by the change in default behaviour.
…he module to be idempotent by default Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Alina Buzachis <[email protected]>
aws_s3 - ensure overwrite: different SUMMARY aws_s3 - ensure overwrite: different instead of always in order for the module to be idempotent by default. Fixes: ansible-collections#762 ISSUE TYPE Feature Pull Request COMPONENT NAME aws_s3 Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None>
add patchback configs SUMMARY Add the configs so that we can use the patchback bot for semi-automated backports. ISSUE TYPE Feature Pull Request COMPONENT NAME .github ADDITIONAL INFORMATION Reviewed-by: Felix Fontein <None> Reviewed-by: None <None>
SUMMARY
aws_s3
- ensure overwrite: different instead of always in order for the module to be idempotent by default.Fixes: #762
ISSUE TYPE
COMPONENT NAME
aws_s3