'NoneType' object is not subscriptable error in ec2_vpc_igw module #647

sebastien-rosset · 2022-01-28T17:48:45Z

Summary

When submitting #646 to fix bug #622, the integration tests fail in the ec2_vpc_igw module. This seems to be unrelated to the changes I made in the aws_acm module.

The ec2_vpc_igw module fails with TypeError: 'NoneType' object is not subscriptable. I don't think the module should ever fail with a NoneType error.

Issue Type

Bug Report

Component Name

ec2_vpc_igw

Ansible Version

The environment (ansible version, collection version, SDK, OS...) is entirely determined by the PR process. The failures of the integration tests are here: #646 and https://ansible.softwarefactory-project.io/zuul/build/cb5198eefa104eeb9cd5c8bc6e12bdc1

It's not clear which part of the zuul logs contain the details about the environment. I've copy-pasted some data from the zuul logs.

2022-01-28 14:24:20.068273 | 
2022-01-28 14:24:20.068478 | TASK [emit-job-header : Print job information]
2022-01-28 14:24:20.662964 | # Job Information
2022-01-28 14:24:20.663164 | Ansible Version: 2.9.16
2022-01-28 14:24:20.663198 | Job: ansible-test-cloud-integration-aws-py38_3
2022-01-28 14:24:20.663225 | Pipeline: check
2022-01-28 14:24:20.663250 | Executor: ze06.softwarefactory-project.io
2022-01-28 14:24:20.663275 | Triggered by: https://github.com/ansible-collections/amazon.aws/pull/646
2022-01-28 14:24:20.663299 | Log URL (when completed): https://ansible.softwarefactory-project.io/logs/46/646/d444627c887c44c244ef257e68d45a892f10f772/check/ansible-test-cloud-integration-aws-py38_3/cb5198e/
2022-01-28 14:24:20.663324 | Event ID: 79a6d1b0-8044-11ec-8e57-1426c1318593

Collection Versions

$ ansible-galaxy collection list

AWS SDK versions

$ pip show boto boto3 botocore

Configuration

$ ansible-config dump --only-changed

OS / Environment

No response

Steps to Reproduce

Expected Results

I expected the PR integration tests to complete without error. Or at least to complete without any error outside the changes I made.
More specifically:

The integration tests for the ec2_vpc_igw module should not fail.
When a problem does occur in the ec2_vpc_igw module, it should handle the error more gracefully, not by raising a'NoneType' object is not subscriptable exception

"/tmp/ansible_ec2_vpc_igw_payload_g4o1kl_r/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py", line 158, in get_igw_info
TypeError: 'NoneType' object is not subscriptable

Actual Results

The PR integration tests fail in the following modules:

ERROR: The 2 integration test(s) listed below (out of 8) failed. See error output above for details:
ec2_vpc_igw
ec2_vpc_route_table

Here is a specific stack trace for the ec2_vpc_igw module.

Traceback (most recent call last):
  File "<stdin>", line 121, in <module>
  File "<stdin>", line 113, in _ansiballz_main
  File "<stdin>", line 61, in invoke_module
  File "/usr/lib64/python3.8/runpy.py", line 207, in run_module
    return _run_module_code(code, init_globals, run_name, mod_spec)
  File "/usr/lib64/python3.8/runpy.py", line 97, in _run_module_code
    _run_code(code, mod_globals, init_globals,
  File "/usr/lib64/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/tmp/ansible_ec2_vpc_igw_payload_g4o1kl_r/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py", line 248, in <module>
  File "/tmp/ansible_ec2_vpc_igw_payload_g4o1kl_r/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py", line 242, in main
  File "/tmp/ansible_ec2_vpc_igw_payload_g4o1kl_r/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py", line 132, in process
  File "/tmp/ansible_ec2_vpc_igw_payload_g4o1kl_r/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py", line 220, in ensure_igw_present
  File "/tmp/ansible_ec2_vpc_igw_payload_g4o1kl_r/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py", line 158, in get_igw_info
TypeError: 'NoneType' object is not subscriptable

Code of Conduct

I agree to follow the Ansible Code of Conduct

The text was updated successfully, but these errors were encountered:

ansibullbot · 2022-01-28T17:53:43Z

Files identified in the description:

[plugins/modules/ec2_vpc_igw.py](https://github.com/['ansible-collections/amazon.aws', 'ansible-collections/community.aws', 'ansible-collections/community.vmware']/blob/main/plugins/modules/ec2_vpc_igw.py)

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

ansibullbot · 2022-01-28T17:53:44Z

cc @jillr @s-hertel @tremble
click here for bot help

alinabuzachis · 2022-02-01T10:47:08Z

This PR #672 should fix it.

jatorcasso · 2022-02-23T02:07:21Z

@alinabuzachis I'm still running into this issue when running integration tests for ec2_vpc_route_table

Traceback (most recent call last):
  File "<stdin>", line 121, in <module>
  File "<stdin>", line 113, in _ansiballz_main
  File "<stdin>", line 61, in invoke_module
  File "/usr/lib64/python3.8/runpy.py", line 207, in run_module
    return _run_module_code(code, init_globals, run_name, mod_spec)
  File "/usr/lib64/python3.8/runpy.py", line 97, in _run_module_code
    _run_code(code, mod_globals, init_globals,
  File "/usr/lib64/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/tmp/ansible_ec2_vpc_igw_payload_jxieg1a_/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py", line 249, in <module>
  File "/tmp/ansible_ec2_vpc_igw_payload_jxieg1a_/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py", line 243, in main
  File "/tmp/ansible_ec2_vpc_igw_payload_jxieg1a_/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py", line 132, in process
  File "/tmp/ansible_ec2_vpc_igw_payload_jxieg1a_/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py", line 221, in ensure_igw_present
  File "/tmp/ansible_ec2_vpc_igw_payload_jxieg1a_/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py", line 158, in get_igw_info
TypeError: 'NoneType' object is not subscriptable
fatal: [testhost]: FAILED! => {
    "changed": false,
    "module_stderr": "Traceback (most recent call last):\n  File \"<stdin>\", line 121, in <module>\n  File \"<stdin>\", line 113, in _ansiballz_main\n  File \"<stdin>\", line 61, in invoke_module\n  File \"/usr/lib64/python3.8/runpy.py\", line 207, in run_module\n    return _run_module_code(code, init_globals, run_name, mod_spec)\n  File \"/usr/lib64/python3.8/runpy.py\", line 97, in _run_module_code\n    _run_code(code, mod_globals, init_globals,\n  File \"/usr/lib64/python3.8/runpy.py\", line 87, in _run_code\n    exec(code, run_globals)\n  File \"/tmp/ansible_ec2_vpc_igw_payload_jxieg1a_/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py\", line 249, in <module>\n  File \"/tmp/ansible_ec2_vpc_igw_payload_jxieg1a_/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py\", line 243, in main\n  File \"/tmp/ansible_ec2_vpc_igw_payload_jxieg1a_/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py\", line 132, in process\n  File \"/tmp/ansible_ec2_vpc_igw_payload_jxieg1a_/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py\", line 221, in ensure_igw_present\n  File \"/tmp/ansible_ec2_vpc_igw_payload_jxieg1a_/ansible_ec2_vpc_igw_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_igw.py\", line 158, in get_igw_info\nTypeError: 'NoneType' object is not subscriptable\n",

ec2_vpc_igw: fix 'NoneType' object is not subscriptable Depends-On: ansible/ansible-zuul-jobs#1368 SUMMARY Add "InternetGatewayAttached" waiter Fixes #647 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None> Reviewed-by: Abhijeet Kasurde <None>

…ections#691) ec2_vpc_igw: fix 'NoneType' object is not subscriptable Depends-On: ansible/ansible-zuul-jobs#1368 SUMMARY Add "InternetGatewayAttached" waiter Fixes ansible-collections#647 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None> Reviewed-by: Abhijeet Kasurde <None>

sebastien-rosset · 2022-03-01T18:38:25Z

I still see the issue when I run the integration tests in #631

jatorcasso · 2022-03-02T02:32:48Z

So adding a waiter after attaching the igw still isnt enough it seems? Thoughts on waiting for igw after ensuring tags? @alinabuzachis

alinabuzachis · 2022-03-02T09:07:20Z

So adding a waiter after attaching the igw still isnt enough it seems? Thoughts on waiting for igw after ensuring tags? @alinabuzachis

Ok, I will also try to have a look if the error persists. BTW, the CI seems green now. @sebastien-rosset please feel free to open an issue if you encounter this issue again.

jatorcasso · 2022-03-02T23:07:36Z

The waiter I added after attaching definitely helps - it used to fail about 10% of the time and now its about 2% of the time (I ran bash scripts to run 50 iterations) - but the main problem is just the instability of calling describe_internet_gateways. We might just have to do a manual waiter prior to calling ensure_ec2_tags then again after and just return the gw directly to make 100% sure we have the object. Not pretty but I'm not sure what else we can do.

@alinabuzachis

`ec2_vpc_igw`: fix NoneType error SUMMARY use paginator for describe internet gateways and add retry_codes='InvalidInternetGatewayID.NotFound' (thanks @alinabuzachis) Fixes #647 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw ADDITIONAL INFORMATION previously added InternetGatewayAttached waiter but problem still persists (#691) Reviewed-by: Abhijeet Kasurde <None> Reviewed-by: Jill R <None>

…ections#691) ec2_vpc_igw: fix 'NoneType' object is not subscriptable Depends-On: ansible/ansible-zuul-jobs#1368 SUMMARY Add "InternetGatewayAttached" waiter Fixes ansible-collections#647 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None> Reviewed-by: Abhijeet Kasurde <None> (cherry picked from commit 8cc9397)

ec2_vpc_igw: fix 'NoneType' object is not subscriptable (#691) Manual backport to stable-3: ec2_vpc_igw: fix 'NoneType' object is not subscriptable SUMMARY Add "InternetGatewayAttached" waiter Fixes #647 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw Reviewed-by: Alina Buzachis Reviewed-by: Joseph Torcasso Reviewed-by: Jill R Reviewed-by: Abhijeet Kasurde (cherry picked from commit 8cc9397) SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION

ec2_vpc_igw: fix 'NoneType' object is not subscriptable (#691) Manual backport to stable-2: ec2_vpc_igw: fix 'NoneType' object is not subscriptable SUMMARY Add "InternetGatewayAttached" waiter Fixes #647 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw Reviewed-by: Alina Buzachis Reviewed-by: Joseph Torcasso Reviewed-by: Jill R Reviewed-by: Abhijeet Kasurde (cherry picked from commit 8cc9397) SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION

@alinabuzachis

`ec2_vpc_igw`: fix NoneType error SUMMARY use paginator for describe internet gateways and add retry_codes='InvalidInternetGatewayID.NotFound' (thanks @alinabuzachis) Fixes ansible-collections#647 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw ADDITIONAL INFORMATION previously added InternetGatewayAttached waiter but problem still persists (ansible-collections#691) Reviewed-by: Abhijeet Kasurde <None> Reviewed-by: Jill R <None> (cherry picked from commit 1965b05)

@alinabuzachis

`ec2_vpc_igw`: fix NoneType error SUMMARY use paginator for describe internet gateways and add retry_codes='InvalidInternetGatewayID.NotFound' (thanks @alinabuzachis) Fixes ansible-collections#647 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw ADDITIONAL INFORMATION previously added InternetGatewayAttached waiter but problem still persists (ansible-collections#691) Reviewed-by: Abhijeet Kasurde <None> Reviewed-by: Jill R <None> (cherry picked from commit 1965b05)

@alinabuzachis

`ec2_vpc_igw`: fix NoneType error (#695) ec2_vpc_igw: fix NoneType error SUMMARY use paginator for describe internet gateways and add retry_codes='InvalidInternetGatewayID.NotFound' (thanks @alinabuzachis) Fixes #647 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw ADDITIONAL INFORMATION previously added InternetGatewayAttached waiter but problem still persists (#691) Reviewed-by: Abhijeet Kasurde Reviewed-by: Jill R (cherry picked from commit 1965b05) SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION

@alinabuzachis

`ec2_vpc_igw`: fix NoneType error (#695) ec2_vpc_igw: fix NoneType error SUMMARY use paginator for describe internet gateways and add retry_codes='InvalidInternetGatewayID.NotFound' (thanks @alinabuzachis) Fixes #647 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw ADDITIONAL INFORMATION previously added InternetGatewayAttached waiter but problem still persists (#691) Reviewed-by: Abhijeet Kasurde Reviewed-by: Jill R (cherry picked from commit 1965b05) SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION

jatorcasso · 2022-03-21T18:51:37Z

I ran into this issue again

alinabuzachis · 2022-04-03T12:23:39Z

@jatorcasso Where did you hit this error?

jatorcasso · 2022-04-04T15:39:17Z

@jatorcasso Where did you hit this error?

I got it a few times here and there locally, but also saw it on CI tests https://ansible.softwarefactory-project.io/zuul/build/8e3437bcad9b4099af9dc081dfa70649

ec2_vpc_igw - dont user filters to paginate to fix NoneType error Depends-On: ansible/ansible-zuul-jobs#1498 SUMMARY Use gateway id when describing gateway instances as opposed to filters if possible to avoid bug of no gateways found. Fixes #647 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw Reviewed-by: Gonéri Le Bouder <[email protected]> Reviewed-by: Mark Chappell <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Alina Buzachis <None>

ansibullbot added bug This issue/PR relates to a bug module module needs_triage plugins plugin (any type) python3 traceback labels Jan 28, 2022

sebastien-rosset mentioned this issue Jan 28, 2022

Handle ResourceNotFoundException while iterating certificates #646

Merged

ansibullbot added the has_pr label Jan 28, 2022

alinabuzachis removed the needs_triage label Feb 1, 2022

alinabuzachis linked a pull request Feb 11, 2022 that will close this issue

ec2_vpc_igw: fix 'NoneType' object is not subscriptable #672

Merged

softwarefactory-project-zuul bot closed this as completed in #672 Feb 16, 2022

jillr reopened this Feb 23, 2022

jatorcasso mentioned this issue Feb 24, 2022

ec2_vpc_igw: fix 'NoneType' object is not subscriptable #691

Merged

softwarefactory-project-zuul bot closed this as completed in #691 Mar 1, 2022

sebastien-rosset mentioned this issue Mar 1, 2022

vpc_net check mode, IPV6 CIDR assoc/disassoc #631

Merged

jillr reopened this Mar 2, 2022

jatorcasso mentioned this issue Mar 3, 2022

ec2_vpc_igw: fix NoneType error #695

Merged

softwarefactory-project-zuul bot closed this as completed in #695 Mar 4, 2022

alinabuzachis mentioned this issue Mar 4, 2022

ec2_vpc_igw: fix 'NoneType' object is not subscriptable (#691) #697

Merged

alinabuzachis mentioned this issue Mar 4, 2022

ec2_vpc_igw: fix 'NoneType' object is not subscriptable (#691) #698

Merged

alinabuzachis mentioned this issue Mar 11, 2022

ec2_vpc_igw: fix NoneType error (#695) #705

Merged

alinabuzachis mentioned this issue Mar 11, 2022

ec2_vpc_igw: fix NoneType error (#695) #706

Merged

jatorcasso reopened this Apr 1, 2022

jatorcasso mentioned this issue Apr 1, 2022

ec2_vpc_igw - dont user filters to paginate to fix NoneType error #766

Merged

goneri added the CI label Apr 5, 2022

softwarefactory-project-zuul bot closed this as completed in #766 Apr 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

'NoneType' object is not subscriptable error in ec2_vpc_igw module #647

'NoneType' object is not subscriptable error in ec2_vpc_igw module #647

sebastien-rosset commented Jan 28, 2022 •

edited

Loading

ansibullbot commented Jan 28, 2022

ansibullbot commented Jan 28, 2022

alinabuzachis commented Feb 1, 2022 •

edited

Loading

jatorcasso commented Feb 23, 2022

sebastien-rosset commented Mar 1, 2022

jatorcasso commented Mar 2, 2022

alinabuzachis commented Mar 2, 2022 •

edited

Loading

jatorcasso commented Mar 2, 2022 •

edited

Loading

jatorcasso commented Mar 21, 2022

alinabuzachis commented Apr 3, 2022

jatorcasso commented Apr 4, 2022

'NoneType' object is not subscriptable error in ec2_vpc_igw module #647

'NoneType' object is not subscriptable error in ec2_vpc_igw module #647

Comments

sebastien-rosset commented Jan 28, 2022 • edited Loading

Summary

Issue Type

Component Name

Ansible Version

Collection Versions

AWS SDK versions

Configuration

OS / Environment

Steps to Reproduce

Expected Results

Actual Results

Code of Conduct

ansibullbot commented Jan 28, 2022

ansibullbot commented Jan 28, 2022

alinabuzachis commented Feb 1, 2022 • edited Loading

jatorcasso commented Feb 23, 2022

sebastien-rosset commented Mar 1, 2022

jatorcasso commented Mar 2, 2022

alinabuzachis commented Mar 2, 2022 • edited Loading

jatorcasso commented Mar 2, 2022 • edited Loading

jatorcasso commented Mar 21, 2022

alinabuzachis commented Apr 3, 2022

jatorcasso commented Apr 4, 2022

sebastien-rosset commented Jan 28, 2022 •

edited

Loading

alinabuzachis commented Feb 1, 2022 •

edited

Loading

alinabuzachis commented Mar 2, 2022 •

edited

Loading

jatorcasso commented Mar 2, 2022 •

edited

Loading