Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_vpc_igw - dont user filters to paginate to fix NoneType error #766

Merged
merged 3 commits into from
Apr 22, 2022
Merged

ec2_vpc_igw - dont user filters to paginate to fix NoneType error #766

merged 3 commits into from
Apr 22, 2022

Conversation

jatorcasso
Copy link
Contributor

@jatorcasso jatorcasso commented Apr 1, 2022 •
edited
Loading

Depends-On: ansible/ansible-zuul-jobs#1498

SUMMARY

Use gateway id when describing gateway instances as opposed to filters if possible to avoid bug of no gateways found.

Fixes #647

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_vpc_igw

@ansibullbot
Copy link

cc @jillr @s-hertel @tremble
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module needs_triage plugins plugin (any type) labels Apr 1, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@jatorcasso jatorcasso changed the title ec2_vpc_igw - add manual waiter for NoneType error ec2_vpc_igw - dont user filters to paginate to fix NoneType error Apr 20, 2022
@jatorcasso jatorcasso force-pushed the ec2_vpc_igw/nonetype-fix-manual-waiter branch from 4f60c4c to ce48e8c Compare April 20, 2022 17:36
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@jatorcasso
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Apr 22, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@jatorcasso
Copy link
Contributor Author

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit cbbf3fb into ansible-collections:main Apr 22, 2022
@renovate renovate bot mentioned this pull request Sep 18, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Oct 4, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Oct 27, 2022
Closed
1 task
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@marknet15
Add missed changelog fragment for dynamodb (ansible-collections#766)
0367fb5 
Add missed changelog fragment for dynamodb

SUMMARY
Add missed change_log fragment for ansible-collections#753
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
dynamodb_table

Reviewed-by: Mark Chappell <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@tremble tremble tremble approved these changes

@goneri goneri goneri approved these changes

@jillr jillr Awaiting requested review from jillr

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review mergeit Merge the PR (SoftwareFactory) module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'NoneType' object is not subscriptable error in ec2_vpc_igw module
5 participants
@jatorcasso @ansibullbot @goneri @tremble @alinabuzachis